Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61348

Quiz reports: counts of number of attempts sometimes wrong in group averages

    XMLWordPrintable

Details

    • MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • MOODLE_33_STABLE, MOODLE_34_STABLE
    • MDL-61348-take2
    • Hide

      This is similar to MDL-57511, MDL-59931 and MDL-60162, so the test set-up is similar.

      Once again, the unit test coverage should be fine, but if you want to verify manually, coy the setup from MDL-60162, then look at the average scores in the Quiz -> Results -> Grades report, but for the overall average, and also when a group is selected.

      Also, if possible, find a quiz with many attempts, running on MySQL, and very that this change does not make performance massively worse.

      Show
      This is similar to MDL-57511 , MDL-59931 and MDL-60162 , so the test set-up is similar. Once again, the unit test coverage should be fine, but if you want to verify manually, coy the setup from MDL-60162 , then look at the average scores in the Quiz -> Results -> Grades report, but for the overall average, and also when a group is selected. Also, if possible, find a quiz with many attempts, running on MySQL, and very that this change does not make performance massively worse.

    Description

      We have a case in our system, where a quiz has 4 attempts, but the quiz report is showing that the group average was computed from (8) grades.

      I have not yet worked out specific steps to reproduce, but I suspect another regression from MDL-27072.

      Attachments

        1. join.png
          join.png
          51 kB
        2. MDL-61348-after.png
          MDL-61348-after.png
          102 kB
        3. MDL-61348-before.png
          MDL-61348-before.png
          101 kB
        4. postgres-explain-take2.PNG
          postgres-explain-take2.PNG
          27 kB
        5. where-in.png
          where-in.png
          52 kB

        Issue Links

          Activity

            People

              timhunt Tim Hunt
              timhunt Tim Hunt
              Shamim Rezaie Shamim Rezaie
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              CiBoT CiBoT
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.