Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61348

Quiz reports: counts of number of attempts sometimes wrong in group averages

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This is similar to MDL-57511, MDL-59931 and MDL-60162, so the test set-up is similar.

      Once again, the unit test coverage should be fine, but if you want to verify manually, coy the setup from MDL-60162, then look at the average scores in the Quiz -> Results -> Grades report, but for the overall average, and also when a group is selected.

      Also, if possible, find a quiz with many attempts, running on MySQL, and very that this change does not make performance massively worse.

      Show
      This is similar to MDL-57511 , MDL-59931 and MDL-60162 , so the test set-up is similar. Once again, the unit test coverage should be fine, but if you want to verify manually, coy the setup from MDL-60162 , then look at the average scores in the Quiz -> Results -> Grades report, but for the overall average, and also when a group is selected. Also, if possible, find a quiz with many attempts, running on MySQL, and very that this change does not make performance massively worse.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61348-take2

      Description

      We have a case in our system, where a quiz has 4 attempts, but the quiz report is showing that the group average was computed from (8) grades.

      I have not yet worked out specific steps to reproduce, but I suspect another regression from MDL-27072.

        Attachments

        1. join.png
          join.png
          51 kB
        2. MDL-61348-after.png
          MDL-61348-after.png
          102 kB
        3. MDL-61348-before.png
          MDL-61348-before.png
          101 kB
        4. postgres-explain-take2.PNG
          postgres-explain-take2.PNG
          27 kB
        5. where-in.png
          where-in.png
          52 kB

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Shamim Rezaie
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18