Loading...

XML

Word

Printable

Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Main Branch:
~~MDL-61348~~-take2
Pull Main Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-61348-take2
Testing Instructions:

Hide

This is similar to ~~MDL-57511~~, ~~MDL-59931~~ and ~~MDL-60162~~, so the test set-up is similar.

Once again, the unit test coverage should be fine, but if you want to verify manually, coy the setup from ~~MDL-60162~~, then look at the average scores in the Quiz -> Results -> Grades report, but for the overall average, and also when a group is selected.

Also, if possible, find a quiz with many attempts, running on MySQL, and very that this change does not make performance massively worse.

Show
This is similar to MDL-57511 , MDL-59931 and MDL-60162 , so the test set-up is similar. Once again, the unit test coverage should be fine, but if you want to verify manually, coy the setup from MDL-60162 , then look at the average scores in the Quiz -> Results -> Grades report, but for the overall average, and also when a group is selected. Also, if possible, find a quiz with many attempts, running on MySQL, and very that this change does not make performance massively worse.

We have a case in our system, where a quiz has 4 attempts, but the quiz report is showing that the group average was computed from (8) grades.

I have not yet worked out specific steps to reproduce, but I suspect another regression from ~~MDL-27072~~.

has a non-specific relationship to

MDL-57511 Attempts report showing non-unique debugging when including enroled users

MDL-59931 Quiz grades results report -- pagination is very incorrect

MDL-60162 Downloading quiz attempts report gets 'Did you remember to make the first column something unique in your call to get_records?' error

is a regression caused by

MDL-27072 Quiz reports should use enroled users code, not get_users_by_capability

Participants:: CiBoT, David Monllaó, Eloy Lafuente (stronk7), Shamim Rezaie, Tim Hunt