Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61348

Quiz reports: counts of number of attempts sometimes wrong in group averages

    XMLWordPrintable

Details

    • MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • MOODLE_33_STABLE, MOODLE_34_STABLE
    • MDL-61348-take2
    • Hide

      This is similar to MDL-57511, MDL-59931 and MDL-60162, so the test set-up is similar.

      Once again, the unit test coverage should be fine, but if you want to verify manually, coy the setup from MDL-60162, then look at the average scores in the Quiz -> Results -> Grades report, but for the overall average, and also when a group is selected.

      Also, if possible, find a quiz with many attempts, running on MySQL, and very that this change does not make performance massively worse.

      Show
      This is similar to MDL-57511 , MDL-59931 and MDL-60162 , so the test set-up is similar. Once again, the unit test coverage should be fine, but if you want to verify manually, coy the setup from MDL-60162 , then look at the average scores in the Quiz -> Results -> Grades report, but for the overall average, and also when a group is selected. Also, if possible, find a quiz with many attempts, running on MySQL, and very that this change does not make performance massively worse.

    Description

      We have a case in our system, where a quiz has 4 attempts, but the quiz report is showing that the group average was computed from (8) grades.

      I have not yet worked out specific steps to reproduce, but I suspect another regression from MDL-27072.

      Attachments

        1. join.png
          51 kB
          Shamim Rezaie
        2. MDL-61348-after.png
          102 kB
          Shamim Rezaie
        3. MDL-61348-before.png
          101 kB
          Shamim Rezaie
        4. postgres-explain-take2.PNG
          27 kB
          Tim Hunt
        5. where-in.png
          52 kB
          Shamim Rezaie

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-57511 Attempts report showing non-unique debugging when including enroled users

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-59931 Quiz grades results report -- pagination is very incorrect

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-60162 Downloading quiz attempts report gets 'Did you remember to make the first column something unique in your call to get_records?' error

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27072 Quiz reports should use enroled users code, not get_users_by_capability

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              timhunt Tim Hunt
              timhunt Tim Hunt
              Shamim Rezaie Shamim Rezaie
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              CiBoT CiBoT
              Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                17/May/18