Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61378

Forum: Improve structure of forum post HTML

XMLWordPrintable

    • MOODLE_34_STABLE, MOODLE_36_STABLE
    • MOODLE_36_STABLE
    • MDL-61378-master
    • Hide

      Covered by behat tests and unit tests.

      Setup:

      Create a forum, post a discussion and add some replies with file attachments.

      Testing:

      1. Verify that the forum displays each post as it did before.

      2. Verify that after following a "permalink" to a forum post, the post has a border on the left (so it looks like the "current" post)

       

      Show
      Covered by behat tests and unit tests. Setup: Create a forum, post a discussion and add some replies with file attachments. Testing: 1. Verify that the forum displays each post as it did before. 2. Verify that after following a "permalink" to a forum post, the post has a border on the left (so it looks like the "current" post)  

      HTML structure of a forum post can be improved.

      Improvements:

      1. Use <article> tag to mark it correctly.
      2. Use <time> tag to include the real datetime information.
      3. Use <address> tag to specify who and when the post came from.
      4. Use heading level tags to mark the subject of each post.
      5. Properly nest reply posts within their parent <article>
      6. Use a header tab for each article to split the metadata from the content.
      7. Use CSS to separate links, not text content.

        1. MDL-62378-with.png
          MDL-62378-with.png
          55 kB
        2. MDL-62378-without.png
          MDL-62378-without.png
          55 kB
        3. image-2018-10-10-08-19-17-200.png
          image-2018-10-10-08-19-17-200.png
          69 kB

            damyon Damyon Wiese
            kedgar Kim Edgar
            Andrew Lyons Andrew Lyons
            David Monllaó David Monllaó
            Janelle Barcega Janelle Barcega
            Votes:
            6 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 minutes
                4m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.