Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61379

mod_lti unit tests fail when TEST_EXTERNAL_FILES_HTTPS_URL is defined

    XMLWordPrintable

    Details

      Description

      The hardcoded URL from tests/fixtures/ims_cartridge_basic_lti_link.xml
      doesn't match the expected value in the unit tests if TEST_EXTERNAL_FILES_HTTPS_URL is defined.

      The attached patch fixes the test by using the same hardcoded URL instead of the generated one. It applies cleanly on all supported versions.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            peikk0 Pierre Guinoiseau
            Peer reviewer:
            Mark Nelson
            Integrator:
            David Monllaó
            Tester:
            CiBoT
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              19/Mar/18