[MDL-61394] Add an experimental feature to allow the use of SassC for scss compilation - Moodle Tracker

XML

Word

Printable

Details

Type: New Feature
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5
Fix Version/s: 3.5
Component/s: Administration, Themes
Labels:

Affected Branches:
MOODLE_35_STABLE
Fixed Branches:
MOODLE_35_STABLE
Pull from Repository:
git://git.cameron1729.xyz/moodle.git
Pull Master Branch:
~~MDL-61394~~-master
Pull Master Diff URL:
http://git.cameron1729.xyz/?p=moodle.git;a=commitdiff;h=MDL-61394-master&hp=d1b4ca921e8317195a78a6ca35eae27d0bec2828
Testing Instructions:
Hide

Prerequisites

The SassC compiler installed somewhere on your system (instructions here: https://github.com/sass/sassc)

Log in as admin and browse to "Site administration" > "Development" > "Experimental" > "Experimental settings"

Enter the path to the sassc binary

Browse to "Site administration" > "Appearance" > "Themes" > "Boost"

Change the brand colour and press "Save settings"

Verify that the site's brand colour has changed and that there are no scss errors in your apache log (you might have to refresh the page again for the colour to change

Repeat the above with an RTL language installed
Show
Prerequisites The SassC compiler installed somewhere on your system (instructions here: https://github.com/sass/sassc ) Log in as admin and browse to "Site administration" > "Development" > "Experimental" > "Experimental settings" Enter the path to the sassc binary Browse to "Site administration" > "Appearance" > "Themes" > "Boost" Change the brand colour and press "Save settings" Verify that the site's brand colour has changed and that there are no scss errors in your apache log (you might have to refresh the page again for the colour to change Repeat the above with an RTL language installed

Description

The PHP compiler is expensive and causes problems in cloud environments. It would be cool to be able to specify the path to SassC - which is a compiler written in C that uses the defacto libsass library.

Attachments

Issue Links

caused a regression

MDL-64564 SCSS theme setting validation different when using $CFG->pathtosassc

Open

has been marked as being related by

MDL-57875 SCSS PHP compiler does not support the '@import url' at-rule.

Open

is duplicated by

MDL-58610 invalid .css/.scss in theme/boost/moodle/forms.scss

Closed

Activity

People

Assignee:: cameron1729

Reporter:: cameron1729

Peer reviewer:: Ryan Wyllie

Integrator:: Andrew Lyons

Tester:: Bas Brands

Participants:: Andrew Lyons, Bas Brands, cameron1729, CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Mary Cooch, Ryan Wyllie

Component watchers:: Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May

Votes:: 0 Vote for this issue

Watchers:: 10 Start watching this issue

Dates

Created:: 08/Feb/18 7:58 PM

Updated:: 13/Oct/19 8:15 PM

Resolved:: 23/Feb/18 11:02 PM

Fix Release Date:: 17/May/18