Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61404

Blocks: String 'leaveblanktohide' is never used

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.5
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide
      • Go to your Moodle instance located on the server.
      • Open file blocks/html/lang/en/block_html.php and make sure that string['leaveblanktohide'] is not existing
      • Open file blocks/mentees/lang/en/block_mentees.php and make sure that string['leaveblanktohide'] is not existing
      Show
      Go to your Moodle instance located on the server. Open file blocks/html/lang/en/block_html.php and make sure that string ['leaveblanktohide'] is not existing Open file blocks/mentees/lang/en/block_mentees.php and make sure that string ['leaveblanktohide'] is not existing
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull Master Branch:
      MDL-61404-master

      Description

      Hi,

      whilst developing a block plugin I stumbled over the string:

      $string['leaveblanktohide'] = 'leave blank to hide the title';
      

      This string is defined in two blocks, however they are never used in the code:
      https://github.com/moodle/moodle/search?utf8=✓&q=leaveblanktohide
      So, this useless string definition could be omitted.

      Best, Kathrin

        Attachments

          Activity

            People

            Assignee:
            kosswa Kathrin Osswald
            Reporter:
            kosswa Kathrin Osswald
            Peer reviewer:
            Tomasz Muras
            Integrator:
            Andrew Nicols
            Tester:
            Gladys Basiana
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              17/May/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m