Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61408

Missing button style for "Check" button on quiz

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.3, 3.4.1
    • Fix Version/s: 3.3.5, 3.4.2
    • Component/s: Quiz, Themes
    • Labels:
    • Testing Instructions:
      Hide
      • Add a quiz to your course with "Question behaviour" → "How questions behave": "Interactive with multiple tries"
      • Add a question to your quiz
      • Enrol a student to your course
      • As student, open the quiz in iOS Safari (the XCode Simulator comes handy)
      • Cross check the button is styled as button
      Show
      Add a quiz to your course with "Question behaviour" → "How questions behave": "Interactive with multiple tries" Add a question to your quiz Enrol a student to your course As student, open the quiz in iOS Safari (the XCode Simulator comes handy) Cross check the button is styled as button
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61408-master

      Description

      Moodle version: 3.3.3+

      Theme: BOOST

      Activity: Quiz (Question behave => Interactive with multiple tries)

      Browser: iOS Safari / iOS Firefox

      Affected: The "Check" button is missing style in questions.

       

      After study, it is caused by different rendering of inputs and buttons on iOS browsers. As BOOST is using Bootstrap v4, all default button style should be ".btn .btn-default" than just a ".btn" (Reference: https://github.com/twbs/bootstrap/issues/11855). And I found the style of the mentioned "Check" button contains only class ".btn". The suggested quick fix is just adding ".btn-default" for those default style buttons.

        Attachments

        1. check_btn_mobile.PNG
          65 kB
          Harold Yung
        2. check_btn_PC.PNG
          24 kB
          Harold Yung
        3. MDL-61408_Confirmed and Verified_iOS Safari.jpg
          176 kB
          Gladys Basiana
        4. MDL-61408-after.png
          78 kB
          Luca Bösch
        5. MDL-61408-before.png
          79 kB
          Luca Bösch
        6. MDL-61408-iOS-after.png
          214 kB
          Luca Bösch
        7. MDL-61408-iOS-before.png
          206 kB
          Luca Bösch

          Activity

            People

            Assignee:
            lucaboesch Luca Bösch
            Reporter:
            haroldyung Harold Yung
            Peer reviewer:
            Tim Hunt
            Integrator:
            Andrew Nicols
            Tester:
            Gladys Basiana
            Participants:
            Component watchers:
            Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              19/Mar/18