Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61444

Add new question tags capabilities and replace existing checks

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.5
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. If you don’t have a course, create one.
      3. Enrol two users (t1, t2) as teachers in that course.
      4. Go to that course, click on the cog icon and then More…
      5. Click on Question Bank link and then click Create a new question
      6. Add a new essay question and save.
      7. Now log in as the t1 and go to question bank again.
      8. Add another question, this time name it something that refer to your user, for example “t1 question” and save.
      9. On the question bank, click the tag icon.
      10. Make sure the tag field is visible and you are able to add a tag.
      11. Add some tag to the question related to your user t1tag for example and save.
      12. Click again on the tag icon, make sure the tag is displayed and the tag field is visible.
      13. Now log in as teacher 2 (t2), go to question bank and repeat steps 8 to 12.
      14. Log in as admin.
      15. Go to that course, click on the cog and More…
      16. Then, click Users > Permission.
      17. Search for moodle/question:tagall and remove Teacher role by clicking the trash icon.
      18. Now log in as t1 again and go to question bank.
      19. Make sure tag icon still visible for all questions.
      20. Click on the question you created for your user.
      21. Make sure the tag field is visible and you are able to add more tags and remove.
      22. Now click on the tag icon of a question related to other teacher (t2)
      23. You should be able to see the tag (in text) but you should not see the tag icon.
      24. Log in as t2 again and go to question bank.
      25. Make sure tag icon still visible for all questions.
      26. Click on the question you created for your user.
      27. Make sure the tag field is visible and you are able to add more tags and remove.
      28. Now click on the tag icon of a question related to other teacher (t1)
      29. You should be able to see the tag (in text) but you should not see the tag icon.
      30. Log in as admin again and go to that course.
      31. Assign editall capability to teacher role.
      32. Log in as teacher 1 (t1) and go to the question bank of that course.
      33. Click on the cog icon of your own question
      34. Make sure you are able to add/remove tags.
      35. Now go back to question bank list and click on the cog icon of a different teacher (t2)
      36. Go to the tag section, you should not be able to add/remove tags
      37. You should be able to see the tags text (the element should be frozen)
      38. Save the form, make sure the tags are not deleted.
      Show
      Log in as admin If you don’t have a course, create one. Enrol two users (t1, t2) as teachers in that course. Go to that course, click on the cog icon and then More… Click on Question Bank link and then click Create a new question Add a new essay question and save. Now log in as the t1 and go to question bank again. Add another question, this time name it something that refer to your user, for example “t1 question” and save. On the question bank, click the tag icon. Make sure the tag field is visible and you are able to add a tag. Add some tag to the question related to your user t1tag for example and save. Click again on the tag icon, make sure the tag is displayed and the tag field is visible. Now log in as teacher 2 (t2), go to question bank and repeat steps 8 to 12. Log in as admin. Go to that course, click on the cog and More… Then, click Users > Permission. Search for moodle/question:tagall and remove Teacher role by clicking the trash icon. Now log in as t1 again and go to question bank. Make sure tag icon still visible for all questions. Click on the question you created for your user. Make sure the tag field is visible and you are able to add more tags and remove. Now click on the tag icon of a question related to other teacher (t2) You should be able to see the tag (in text) but you should not see the tag icon. Log in as t2 again and go to question bank. Make sure tag icon still visible for all questions. Click on the question you created for your user. Make sure the tag field is visible and you are able to add more tags and remove. Now click on the tag icon of a question related to other teacher (t1) You should be able to see the tag (in text) but you should not see the tag icon. Log in as admin again and go to that course. Assign editall capability to teacher role. Log in as teacher 1 (t1) and go to the question bank of that course. Click on the cog icon of your own question Make sure you are able to add/remove tags. Now go back to question bank list and click on the cog icon of a different teacher (t2) Go to the tag section, you should not be able to add/remove tags You should be able to see the tags text (the element should be frozen) Save the form, make sure the tags are not deleted.
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61444-master

      Description

      At the moment we use question edit capabilities to check whether the user can tag a question or not.

      This issue is about create two new capabities moodle/question:tagall and moodle/question:tagmine and replace existing question capabilities checks for tagging.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              lameze Simey Lameze
              Reporter:
              lameze Simey Lameze
              Peer reviewer:
              Shamim Rezaie
              Integrator:
              Andrew Nicols
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 2 hours, 15 minutes
                  2d 2h 15m