Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61458

Remove the tool_lp/form-cohort-selector for using the cohort form element instead

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.4.1
    • Fix Version/s: None
    • Component/s: Cohorts, Competencies
    • Labels:
      None
    • Affected Branches:
      MOODLE_34_STABLE

      Description

      A new cohort form element was added to Moodle but the tool_lp and tool_cohortroles are using their own form-cohort-selector. We should remove it and replace for using the core/form-cohort-selector one.

      https://github.com/moodle/moodle/blob/master/admin/tool/cohortroles/classes/form/assign_role_cohort.php#L81

      and:
      https://github.com/moodle/moodle/blob/master/admin/tool/lp/classes/form/template_cohorts.php#L51

        Attachments

          Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-49417 Cohort enrollment screen no longer searchable

          • Major - Major loss of function, incorrect output
          • Closed
          will be (partly) resolved by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-62387 Cohort sync dropdown contains redundant entries

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: