Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61458

Remove the tool_lp/form-cohort-selector for using the cohort form element instead

    XMLWordPrintable

Details

    • MOODLE_34_STABLE
    • MOODLE_402_STABLE
    • Hide
      1. Log in as admin
      2. Create a new user
      3. Create two cohorts
      4. Navigate to Users > Permissions > Define roles in site administration
      5. Edit the Manager role
      6. Select User for Context types where this role may be assigned and save
      7. Navigate to Users > Permissions > Assign user roles to cohort in site administration
      8. Select test user for Select users to assign role
      9. For Select cohorts, search for and select both test cohorts
      10. Press Assign and Continue
      11. Confirm under Existing cohort role assignments you see both cohorts listed with appropriate role/user in the table
      Show
      Log in as admin Create a new user Create two cohorts Navigate to Users > Permissions > Define roles in site administration Edit the Manager role Select User for Context types where this role may be assigned and save Navigate to Users > Permissions > Assign user roles to cohort  in site administration Select test user for Select users to assign role For Select cohorts , search for and select both test cohorts Press Assign and Continue Confirm under Existing cohort role assignments you see both cohorts listed with appropriate role/user in the table

    Description

      A new cohort form element was added to Moodle but the tool_lp and tool_cohortroles are using their own form-cohort-selector. We should remove it and replace for using the core/form-cohort-selector one.

      https://github.com/moodle/moodle/blob/master/admin/tool/cohortroles/classes/form/assign_role_cohort.php#L81

      and:
      https://github.com/moodle/moodle/blob/master/admin/tool/lp/classes/form/template_cohorts.php#L51

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              sarjona Sara Arjona (@sarjona)
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Andrew Lyons Andrew Lyons
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 15 minutes
                  3h 15m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.