Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61482

HTML in date columns in offline grading worksheet

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.4, 3.4.1, 3.5
    • Fix Version/s: 3.4.3, 3.5
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Testing steps:

      1. Create an assignment with offline grading worksheet enabled
      2. Give one of the students a user override, and set the due date and cut-off date
      3. Download the offline grading worksheet
      4. The downloaded grading worksheet should not contain any HTML <div> tags around the following dates:
        • 'Allow submissions from'
        • 'Due date'
        • 'Cut-off date'
      Show
      Testing steps: Create an assignment with offline grading worksheet enabled Give one of the students a user override, and set the due date and cut-off date Download the offline grading worksheet The downloaded grading worksheet should not contain any HTML <div> tags around the following dates: 'Allow submissions from' 'Due date' 'Cut-off date'
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.5 Diff URL:
    • Pull Master Branch:
      MDL-61482-master
    • Pull Master Diff URL:

      Description

      The date columns in the offline grading worksheet (due date and cutoff date) are wrapped in HTML tags, e.g. <div class="duedate">Thursday, 15 February 2018, 12:00 AM</div>

      There is no reason for this and it is potentially confusing for end users. They should be output as the raw date.

      To reproduce, in a course with students:

      1. create an assignment with offline grading worksheet enabled
      2. give one of the students a user override, and set the due date and cut-off date
      3. download the offline grading worksheet
      4. there are due date and cut-off date columns in the worksheet, and the data contains HTML tags

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-44573 Remove HTML tags in the outcomes column in offline grading worksheet

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              zig Zig Tan (Inactive)
              Reporter:
              maherne Michael Aherne
              Peer reviewer:
              Damyon Wiese
              Integrator:
              David Monllaó
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18