Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61521

Category names are not being filtered in course externallib.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.5, 3.4.1, 3.5
    • Fix Version/s: 3.3.6, 3.4.3
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      This minor fix is pretty well covered by unit tests, this is an additional test for the Mobile app that covers one case:

      1. As admin, enable the "Multi-Language Content" filter via Site administration -> Plugins -> Filters -> Manage filters
      2. When enabling it, the field "Apply to" must be set to "Content and headings"
      3. Now go to Site administration -> Courses -> Manage courses and categories, and change the name of the "Miscellanous" category to: "<span lang="en" class="multilang">Miscellaneous</span><span lang="es" class="multilang">Miscellaneous</span>" (just use the cog right to the category and click Edit to be able to change the name)
      4. Now, you need to configure the frontpage to allow to browse courses, for that: Go to "Home", then via the "settings cog" open Edit settings
      5. Enable "List of categories" in the "Front page items when logged in" option and Save changes
      6. Now, enable "Mobile services": Site administration ► Mobile app ► Mobile settings
      7. Access to the site via the Mobile app, go to the Site Home -> Categories and:
        • Check that the name of the "Miscellanous" category is displayed correctly (it just says Miscellanous)
      Show
      This minor fix is pretty well covered by unit tests, this is an additional test for the Mobile app that covers one case: As admin, enable the "Multi-Language Content" filter via Site administration -> Plugins -> Filters -> Manage filters When enabling it, the field "Apply to" must be set to "Content and headings" Now go to Site administration -> Courses -> Manage courses and categories, and change the name of the "Miscellanous" category to: "<span lang="en" class="multilang">Miscellaneous</span><span lang="es" class="multilang">Miscellaneous</span>" (just use the cog right to the category and click Edit to be able to change the name) Now, you need to configure the frontpage to allow to browse courses, for that: Go to "Home", then via the "settings cog" open Edit settings Enable "List of categories" in the "Front page items when logged in" option and Save changes Now, enable "Mobile services": Site administration ► Mobile app ► Mobile settings Access to the site via the Mobile app, go to the Site Home -> Categories and: Check that the name of the "Miscellanous" category is displayed correctly (it just says Miscellanous)
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61521-master

      Description

      The external_format_string should be applied to the category names so filters work as expected

        Attachments

          Activity

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 42 minutes
                42m