Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61529

Update /lib/scssphp from version 0.6.7 to 0.7.5 for Boostrap 4 Stable

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.5
    • Component/s: Libraries
    • Labels:
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61529-master
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      1. Make sure you have the Boost theme selected
      2. purge caches
      3. reload page

      You should not notice any differences.

      Testing scss variables

      1. Go to Site Administration -> Appearance -> Boost
      2. Change brand color
      3. save changes
      4. Reload page twice
      5. Check if brand color applied

      Testing presets

      1. Download a Moodle preset from http://moodle.net/boost
      2. Go to Site Administration -> Appearance -> Boost
      3. Upload preset
      4. Save changes
      5. Reload page twice
      6. See if preset is applied.

       

      Show
      Make sure you have the Boost theme selected purge caches reload page You should not notice any differences. Testing scss variables Go to Site Administration -> Appearance -> Boost Change brand color save changes Reload page twice Check if brand color applied Testing presets Download a Moodle preset from http://moodle.net/boost Go to Site Administration -> Appearance -> Boost Upload preset Save changes Reload page twice See if preset is applied.  

      Description

      When working on integrating Bootstrap 4 Stable the version 0.6.7 shows some unexpected results, theme colours for alerts are off

        Attachments

        1. 3.PNG
          3.PNG
          179 kB
        2. version-0.6.7-compiler.png
          version-0.6.7-compiler.png
          59 kB
        3. version-0.7.5-compiler.png
          version-0.7.5-compiler.png
          61 kB

          Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-56511 Update bootstrap 4 to final release

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              basbrands Bas Brands
              Reporter:
              basbrands Bas Brands
              Peer reviewer:
              David Monllaó David Monllaó
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18