[MDL-61549] Empty Username column (+notices) on Participants page if username is in showuseridentity fields - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.4.1, 3.5
Fix Version/s: 3.4.2
Component/s: Course, Enrolments
Labels:

Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_34_STABLE
Pull from Repository:
git://github.com/Dagefoerde/moodle.git
Pull Main Branch:
~~MDL-61549~~-master
Pull Main Diff URL:
https://github.com/Dagefoerde/moodle/compare/296a3aa707...MDL-61549-master
Testing Instructions:

Hide

1. Add the "username" column to your $CFG->showuseridentity variable (must be in config.php, because the "Username" field is not shown in the admin interface by default).
2. As an administrator, navigate into a course with one or more enrolled users and go to "Participants"
3. Make sure that all enrolled users exhibit a username.

Show
1. Add the "username" column to your $CFG->showuseridentity variable (must be in config.php, because the "Username" field is not shown in the admin interface by default). 2. As an administrator, navigate into a course with one or more enrolled users and go to "Participants" 3. Make sure that all enrolled users exhibit a username.

Description

In our production system, the username column is part of $CFG->showuseridentity. Therefore, (accordingly privileged) users can see a Username column on the participants page (/user/index.php?courseid=xxx). Until Moodle 3.3, that column was filled with respective usernames. However, starting with Moodle 3.4, that column is empty. With the according development settings, PHP notices are displayed as well:

{Notice: Undefined property: stdClass::$username in <snip>/user/classes/participants_table.php on line 420

For organisational reasons we need the contents of the username column to be displayed in Moodle 3.4 as well.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

1.PNG
76 kB
07/Mar/18 9:05 PM

Issue Links

is a regression caused by

MDL-59436 Remove the columns from the participants page that are not in showuseridentity

Closed

Activity

People

Assignee:: Jan Dageförde

Reporter:: Jan Dageförde

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: CiBoT, Eloy Lafuente (stronk7), Jan Dageförde, Janelle Barcega, Sara Arjona (@sarjona)

Votes:: 5 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 28/Feb/18 4:49 AM

Updated:: 09/Mar/18 7:48 AM

Resolved:: 09/Mar/18 7:48 AM

Fix Release Date:: 19/Mar/18

Time Tracking

Estimated:

Remaining:

Logged:

15m