Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61574

Usage of PHP 7 reserved keyword in namespace

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.3.4, 3.4
    • Fix Version/s: 3.5
    • Labels:
    • Testing Instructions:
      Hide

      Testing the new namespaces issue is very challenging. Unfortunately, a regression check of all LTI provider and consumer functions need to be performed. This involves adding an external tool, configuring the tool from the new activity page AND from the manage external tools in the system administration panels as well as providing an activity and/or course.

      Errors found will be immediately apparent because if the namespace is not named correctly, it will completely fail at any stage of the LTI administrative processes. 

      That being said, here are some basic tests for LTI. (be sure to have debugging enabled during the tests).

      LTI Consumer

      1. In a course: Course editing on
      2. Add an activity or resource
      3. Choose "External Tool"
      4. Type in "Activity Name"
      5. Choose a "preconfigured tool" or make a tool using the  button. (try both if you can)
      6. Add the URL and shared secret.
      7. Save the changes

      LTI Provider

      1. In a course: Click on the gear icon (upper right w/Boost) and choose "Published as LTI Tools"
      2. Click "Add"
      3. Choose the "Tool to be published" (course or specific activity)
      4. Click "Add method"
      5. The provided tool will be saved.

      Further testing recommended:

      1. Configure two Moodle sites, one as "Consumer" and one as "Provider".
      2. Follow the steps above for LTI Consumer on the consumer site and LTI Provider on the provider site. 
      3. Make the consumer access a provider tool.
      4. Notice any namespace errors in the debug output.
      Show
      Testing the new namespaces issue is very challenging. Unfortunately, a regression check of all LTI provider and consumer functions need to be performed. This involves adding an external tool, configuring the tool from the new activity page AND from the manage external tools in the system administration panels as well as providing an activity and/or course. Errors found will be immediately apparent because if the namespace is not named correctly, it will completely fail at any stage of the LTI administrative processes.  That being said, here are some basic tests for LTI. (be sure to have debugging enabled during the tests). LTI Consumer In a course: Course editing on Add an activity or resource Choose "External Tool" Type in "Activity Name" Choose a "preconfigured tool" or make a tool using the   button. (try both if you can) Add the URL and shared secret. Save the changes LTI Provider In a course: Click on the gear icon (upper right w/Boost) and choose "Published as LTI Tools" Click "Add" Choose the "Tool to be published" (course or specific activity) Click "Add method" The provided tool will be saved. Further testing recommended: Configure two Moodle sites, one as "Consumer" and one as "Provider". Follow the steps above for LTI Consumer on the consumer site and LTI Provider on the provider site.  Make the consumer access a provider tool. Notice any namespace errors in the debug output.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61574-master

      Description

      CiBoT is complaining abt the namespace 'ltiservice_gradebookservices\local\resource' due to the usage of the soft reserved keyword 'resource' in PHP 7 in MDL-60416. However, there are other places (eg. 'ltiservice_memberships\local\resource') that already exist in core that use this.

        Attachments

          Activity

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18