Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61575

notification_processor_settings.js uses the tool_lp/dialogue

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.4, 3.4.1, 3.4.7, 3.5, 3.5.4, 3.6.2, 3.7
    • Fix Version/s: 3.7
    • Component/s: JavaScript, Messages
    • Labels:
    • Testing Instructions:
      Hide
      1. As an admin, go to Site Administration > Plugins > Message outputs > Manage message outputs and enable Web, Jabber and  Email.  (Don't worry about settings of Jabber, it can be a dummy setting.
      2. Go to Notifications Preferences.
        Expected result: You must see the message outputs that you have enabled.
      3. Open email message output preferences and change value of the select (Email format). After that, press the save button.
      4. Open email message output again: 
        Expected result: check the value of the select is the same as you chose before.
      5. First, check if Jabber message output has Alert icon. Before that, Open Jabber and insert any value in the field Jabber Id. After that, press the save button.
      6. Expected result: Check Jabber message output status and the alert icon has disappeared.
      Show
      As an admin, go to Site Administration > Plugins > Message outputs > Manage message outputs and enable Web, Jabber and  Email.  (Don't worry about settings of Jabber, it can be a dummy setting. Go to Notifications Preferences. Expected result:  You must see the message outputs that you have enabled. Open email message output preferences and change value of the select (Email format). After that, press the save button. Open email message output again:  Expected result:  check the value of the select is the same as you chose before. First, check if Jabber message output has Alert icon. Before that, Open Jabber and insert any value in the field Jabber Id. After that, press the save button. Expected result: Check Jabber message output status and the alert icon has disappeared.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:
      MDL-61575-master

      Description

      Err yeah... we should fix this.

      message/amd/src/notification_processor_settings.js:

      define(['jquery', 'core/ajax', 'core/notification', 'core/fragment', 'core/templates', 'core/str', 'tool_lp/dialogue'],
      

        Attachments

          Activity

            People

            Assignee:
            cescobedo Carlos Escobedo
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Víctor Déniz Falcón
            Integrator:
            Andrew Nicols
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              20/May/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 6 minutes
                2h 6m