-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.3.4, 3.4, 3.5
-
Component/s: External Tool (IMS-LTI)
-
Testing Instructions:
- No testing instructions required. Sanity check the diff. No additional code is being executed, we just removed an if statement that was always returning true.
-
Affected Branches:MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
-
Fixed Branches:MOODLE_33_STABLE, MOODLE_34_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-61576-master -
Pull Master Diff URL:
The variable $typeconfig is never passed, but is used in the function. The only reason it doesn't break is because we use !isset($typeconfig['allowinstructorcustom']) and isset() won't complain. This was discovered reviewing MDL-60416 which will address this issue in 3.5 (assuming it gets integrated), but this still needs fixing in prior supported branches.
