[MDL-61576] The lti_build_custom_parameters function does not contain all necessary params - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.3.4, 3.4, 3.5
Fix Version/s: 3.3.6, 3.4.3
Component/s: External Tool (IMS-LTI)
Labels:
- ci
- triaged

Testing Instructions:
1. No testing instructions required. Sanity check the diff. No additional code is being executed, we just removed an if statement that was always returning true.
Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE
Pull from Repository:
git://github.com/cescobedo/moodle.git
Pull Master Branch:
~~MDL-61576~~-master
Pull Master Diff URL:
https://github.com/cescobedo/moodle/compare/b63a3b04b1...MDL-61576-master

Description

The variable $typeconfig is never passed, but is used in the function. The only reason it doesn't break is because we use !isset($typeconfig['allowinstructorcustom']) and isset() won't complain. This was discovered reviewing ~~MDL-60416~~ which will address this issue in 3.5 (assuming it gets integrated), but this still needs fixing in prior supported branches.

Attachments

Issue Links

blocks

MDL-60416 Support LTI Advantage 1.1

Closed

Discovered while testing

MDL-60416 Support LTI Advantage 1.1

Closed

Activity

People

Assignee:: Carlos Escobedo

Reporter:: Mark Nelson

Peer reviewer:: Mark Nelson

Integrator:: Eloy Lafuente (stronk7)

Tester:: Nobody

Participants:: Andrew Lyons, Carlos Escobedo, chrislawson, CiBoT, Eloy Lafuente (stronk7), Mark Nelson

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 02/Mar/18 8:05 PM

Updated:: 30/Mar/18 1:38 AM

Resolved:: 30/Mar/18 1:38 AM

Fix Release Date:: 17/May/18