Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61623

Invalid ARIA attribute name: aria-role

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.7, 3.4.1, 3.5.4, 3.6
    • Fix Version/s: 3.5.5, 3.6.3
    • Component/s: Accessibility
    • Labels:
    • Testing Instructions:
      Hide
      1. Login to Moodle
      2. Inspect the "notification bell" in the header. 
      3. Verify it has a role="button" attribute on the div containing the bell icon (the one with aria-label="Show notification")
      4. Verify it does not have an aria-role="button" attribute on the div containing the bell icon
      5. Enable completion tracking for a course.
      6. Set the completion tracking for an activity in the course to "Students can manually mark the activity as complete"
      7. Go to course home page
      8. Go to "More..." in the course menu.
      9. Go to the activity completion report
      10. Inspect one of the checkboxes in the table cells for each student.
      11. Verify there is a role="button" attribute on the link tag containing the image (the "a" tag).
      12. Verify it does not have an aria-role="button" attribute.

       

       

      Show
      Login to Moodle Inspect the "notification bell" in the header.  Verify it has a  role="button" attribute on the div containing the bell icon (the one with aria-label="Show notification" ) Verify it does not have an aria-role="button" attribute on the div containing the bell icon Enable completion tracking for a course. Set the completion tracking for an activity in the course to "Students can manually mark the activity as complete" Go to course home page Go to "More..." in the course menu. Go to the activity completion report Inspect one of the checkboxes in the table cells for each student. Verify there is a role="button" attribute on the link tag containing the image (the "a" tag). Verify it does not have an aria-role="button" attribute.    
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.5 Diff URL:
    • Pull 3.6 Branch:
    • Pull 3.6 Diff URL:
    • Pull Master Branch:
      MDL-61623-master
    • Pull Master Diff URL:

      Description

      Running the aXe accessibility checker on default boost theme, I get two "critical" errors on the default dashboard or site pages.

      "Invalid ARIA attribute name: aria-role"

      To replicate,

      1. log into Moodle with Boost theme as authenticated user
      2. Analyze page with the https://www.deque.com/products/aXe/ tool

       

        Attachments

          Activity

            People

            Assignee:
            damyon Damyon Wiese
            Reporter:
            sstrauss@haverford.edu Sharon Strauss
            Peer reviewer:
            Peter Dias
            Integrator:
            Sara Arjona (@sarjona)
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Mar/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m