Moodle
  1. Moodle
  2. MDL-6166

I must not change language strings

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7
    • Component/s: Quiz
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE
    • Rank:
      28455

      Description

      I have mistakenly changed the content of some lang strings while fixing bugs recently. This is bad.

      The correct procedure is to delete old language string, and create a new one with a new name. That way translators can see the strings that need to be retranslated.

      So I need to

      1. Get a list of which strings I have changed from CVS.

      2. Email translation@moodle.org to explain my mistake, and ask them whether they would prefer me to:

      3a. Rename all the changed strings now.

      or

      3b. Give the the list of changed strings so that they can retranslate them.

        Issue Links

          Activity

          Hide
          Martin Dougiamas added a comment -

          From Petr Skoda (skodak at centrum.cz) Wednesday, 26 July 2006, 12:28 AM:

          Well, I did some changes too

          It might be better to automate the process a bit and make a list of added+changed strings for each release and feed it into the translation tool and color it a bit...

          In any case you should not be deleting any strings that might be needed by any 1.6.x version, because the latest language packs are shared in the STABLE and HEAD branch.

          IMO you can improve the English language file, but we should not change the meaning completely - it must make sense in 1.6.X and any later versions.

          Show
          Martin Dougiamas added a comment - From Petr Skoda (skodak at centrum.cz) Wednesday, 26 July 2006, 12:28 AM: Well, I did some changes too It might be better to automate the process a bit and make a list of added+changed strings for each release and feed it into the translation tool and color it a bit... In any case you should not be deleting any strings that might be needed by any 1.6.x version, because the latest language packs are shared in the STABLE and HEAD branch. IMO you can improve the English language file, but we should not change the meaning completely - it must make sense in 1.6.X and any later versions.
          Hide
          Koen Roggemans added a comment -

          It's not a good idea to delete language strings not more in use. Since there is no versioning in the language packs, these language packs should be backwards compatible, at least some time. When clicking the update button, Moodle downloads "the" language pack and that is usually already evolving to the next version.

          Similar for help files: if a helpfile changes a lot from one version to another, the aggreed practice is to make a new one and name it with an index (eg old file: help.html, new file: help2.html etc)

          Show
          Koen Roggemans added a comment - It's not a good idea to delete language strings not more in use. Since there is no versioning in the language packs, these language packs should be backwards compatible, at least some time. When clicking the update button, Moodle downloads "the" language pack and that is usually already evolving to the next version. Similar for help files: if a helpfile changes a lot from one version to another, the aggreed practice is to make a new one and name it with an index (eg old file: help.html, new file: help2.html etc)
          Hide
          Helen Foster added a comment -

          To do: go through CVS history to see what was changed in lang/en_utf8/quiz.php or question_*.php and do as Koen says for any major changes

          Show
          Helen Foster added a comment - To do: go through CVS history to see what was changed in lang/en_utf8/quiz.php or question_*.php and do as Koen says for any major changes
          Hide
          Nicolas Martignoni added a comment -

          Closing, as this seems fixed for quiz. See bug MDL-6645 for other issues related.

          Show
          Nicolas Martignoni added a comment - Closing, as this seems fixed for quiz. See bug MDL-6645 for other issues related.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: