Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61671

The mobile certificate checking is buggy.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Development in progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.4.1
    • Fix Version/s: None
    • Component/s: Administration
    • Labels:
      None

      Description

      The certificate checking in the admin mobile settings report (admin/settings.php?section=mobilesettings) is not checking if the properties actually exist.
      As a result warnings like "It seems that the HTTPS certificate for the site has expired." are shown even with a valid certificate .

      A good sample is the start and end date:

      if (strtotime($cert['Start date']) > $timenow)
      if (strtotime($cert['Expire date']) < $timenow)

      If I change this code to

      if (strtotime($cert['Start Date']) > $timenow)
      if (strtotime($cert['Expire Date']) < $timenow)

      my warnings are gone.

      Every property should be checked using the property_exists function.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jleyva Juan Leyva
              Reporter:
              rdebleu Renaat Debleu
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated: