Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61678

Upgrade phpunit to 6.5.x

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.2, 3.5
    • Fix Version/s: 3.4.3
    • Component/s: Unit tests
    • Labels:
    • Testing Instructions:
      Hide

      A) Automated:

      1. Verify that unit tests pass completely, both with the higher (7.2) and lower (7.0) supported PHP versions (travis is your friend and should be enough).

      B) Manual:

      1. With the patch applied (obviously).
      2. Using the lower (7.0) supported PHP version, delete the composer.lock and run composer install.
      3. Verify that there aren't diffs with the .lock file that was applied in #1 above.
      Show
      A) Automated: Verify that unit tests pass completely, both with the higher (7.2) and lower (7.0) supported PHP versions (travis is your friend and should be enough). B) Manual: With the patch applied (obviously). Using the lower (7.0) supported PHP version, delete the composer.lock and run composer install . Verify that there aren't diffs with the .lock file that was applied in #1 above.
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Right now we are using 6.4.x. This is a minor update within the 6.x series. No changes are required in existing tests. Just fixes:

      https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.5.md

      Strictly we should only apply it to master, cannot see much problem backporting it to 34 (same php versions supported - from 7.0 to 7.2). For integrators discussion.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                stronk7 Eloy Lafuente (stronk7)
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Peer reviewer:
                Andrew Nicols
                Integrator:
                Jun Pataleta
                Tester:
                CiBoT
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  17/May/18