Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61678

Upgrade phpunit to 6.5.x

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.4.2, 3.5
    • 3.4.3
    • Unit tests
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MOODLE_34_STABLE
    • Hide

      A) Automated:

      1. Verify that unit tests pass completely, both with the higher (7.2) and lower (7.0) supported PHP versions (travis is your friend and should be enough).

      B) Manual:

      1. With the patch applied (obviously).
      2. Using the lower (7.0) supported PHP version, delete the composer.lock and run composer install.
      3. Verify that there aren't diffs with the .lock file that was applied in #1 above.
      Show
      A) Automated: Verify that unit tests pass completely, both with the higher (7.2) and lower (7.0) supported PHP versions (travis is your friend and should be enough). B) Manual: With the patch applied (obviously). Using the lower (7.0) supported PHP version, delete the composer.lock and run composer install . Verify that there aren't diffs with the .lock file that was applied in #1 above.

    Description

      Right now we are using 6.4.x. This is a minor update within the 6.x series. No changes are required in existing tests. Just fixes:

      https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.5.md

      Strictly we should only apply it to master, cannot see much problem backporting it to 34 (same php versions supported - from 7.0 to 7.2). For integrators discussion.

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Andrew Lyons Andrew Lyons
              Jun Pataleta Jun Pataleta
              CiBoT CiBoT
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                17/May/18