Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61708

External Tool does not include middlename in "fullname" parameter in request

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Setup
      1. You'll need ngrok running.
      2. Set $CFG->wwwroot in config.php to match the http URL shown by ngrok.
      3. Go to "Site administration / Users / User policies" (/admin/settings.php?section=userpolicies) and set "Full name format" to something like "firstname middlename lastname"
      4. Edit your profile and enter a value for the Middle name field.
      5. Go to "Site administration / Plugins / Activity modules / External tools / Manage tools"
      6. Enter "https://online.dr-chuck.com/sakai-api-test/tp.php" under the "Tool URL..." field.
      7. Click "Add".
      8. On the lower part of the frame, click "Continue to launch_presentation_url"
      9. On the "Manage tools" confirmation page, click "Yes"
      Test
      1. Add an "External tool" activity to a course.
      2. Set a name for this activity.
      3. Set the "Preconfigured tool" field to "Sakai PHP Unit Test"
      4. Save and display.
      5. Confirm that the "lis_person_name_full' parameter shows your full name in "firstname middlename lastname" format.
      Show
      Setup You'll need ngrok running. Set $CFG->wwwroot in config.php to match the http URL shown by ngrok. Go to " Site administration / Users / User policies " (/admin/settings.php?section=userpolicies) and set "Full name format" to something like "firstname middlename lastname" Edit your profile and enter a value for the Middle name field. Go to " Site administration / Plugins / Activity modules / External tools / Manage tools " Enter " https://online.dr-chuck.com/sakai-api-test/tp.php " under the " Tool URL... " field. Click " Add ". On the lower part of the frame, click " Continue to launch_presentation_url " On the "Manage tools " confirmation page, click " Yes " Test Add an " External tool " activity to a course. Set a name for this activity. Set the " Preconfigured tool " field to " Sakai PHP Unit Test " Save and display. Confirm that the "lis_person_name_full' parameter shows your full name in " firstname middlename lastname " format.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61708-lti-fullnamedisplay

      Description

      User's fullname is passed in the request as $USER->firstname . ' ' . $USER->lastname thus completely ignoring fullnamedisplay.

       

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 20 minutes
                20m