Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61711

Update upgrade_stale_php_files_present() before 3.5 release

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.5
    • 3.5
    • Installation
    • None
    • MOODLE_35_STABLE
    • MOODLE_35_STABLE
    • Hide

      web

      1. Create and install a 3.4.x site.
      2. Check out a master site on the just installed site. Before upgrading, touch any of the files that are being detected in the patch, so they exist:
        • lib/dml/mssql_native_moodle_database.php
        • lib/dml/mssql_native_moodle_recordset.php
      3. Do a web based upgrade to master.
      4. A notice ("Mixed Moodle versions detected....") should be displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      5. Delete the touched file(s) in 2. and <<reload>>.
      6. Ensure that the upgrade now will proceed.

      cli

      1. Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.
      Show
      web Create and install a 3.4.x site. Check out a master site on the just installed site. Before upgrading, touch any of the files that are being detected in the patch, so they exist: lib/dml/mssql_native_moodle_database.php lib/dml/mssql_native_moodle_recordset.php Do a web based upgrade to master. A notice ("Mixed Moodle versions detected....") should be displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file(s) in 2. and <<reload>>. Ensure that the upgrade now will proceed. cli Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.

    Description

      Simply verify we have a number (4-5) of files for the next major release. They all must be files deleted since last stable version and current master

      git diff --name-status MOODLE_XX_STABLE..master | grep ^D
      

      Note that it's better not to pick any plugin file that maybe reinstalled manually (exception being forum files because that plugin is mandatory).

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Jake Dallimore Jake Dallimore
              Jun Pataleta Jun Pataleta
              Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                17/May/18