Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61732

Allow "Mathjax" and "Display emoticons as images" filter together, have "y(n)" not breaking

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.6, 3.4.3, 3.5
    • Fix Version/s: 3.4.4, 3.5.1
    • Component/s: Filters
    • Labels:
    • Testing Instructions:
      Hide
      • Enable "Mathjax" and "Display emoticons as images" filter to your page, in "Manage filters" admin/filters.php having them apply to content, place the "Display emoticons as images" filter under the "Mathjax" filter.
      • Go to a course.
      • Insert a label, fill it with an

        y(n)


        expression

        \( y(n) \)

        .

      • Insert a label, fill it with an

        y(t)


        expression

        \( y(t) \)

        .

      • Cross check the

        y(n)


        expression is not breaking and is not displayed as a "thumb down" emoticon.

      Show
      Enable "Mathjax" and "Display emoticons as images" filter to your page, in "Manage filters" admin/filters.php having them apply to content, place the "Display emoticons as images" filter under the "Mathjax" filter. Go to a course. Insert a label, fill it with an y(n) expression \( y(n) \) . Insert a label, fill it with an y(t) expression \( y(t) \) . Cross check the y(n) expression is not breaking and is not displayed as a "thumb down" emoticon.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61732-master

      Description

      When both "Mathjax" and "Display emoticons as images" filter are activated, some Mathjax expressions do break, because they are processed by the "Display emoticons as images" filter later on. The one mentioned in this issue's title is an example.

      Steps to replicate:

      • Enable "Mathjax" and "Display emoticons as images" filter to your page, in "Manage filters" admin/filters.php having them apply to content, place the "Display emoticons as images" filter under the "Mathjax" filter.
      • Go to a course.
      • Insert a label, fill it with an

        y(n)


        expression

        \( y(n) \)

        .

      • Insert a label, fill it with an

        y(t)


        expression

        \( y(t) \)

        .

      • Note that the

        y(n)


        expression is breaking since the

        (n)

        is displayed as a "thumb down" emoticon. The y(t) though, converts correctly.

        Attachments

        1. 0001-MDL-61732-filter_emoticon-Extend-unit-tests.patch
          5 kB
          Andrew Lyons
        2. MDL-61732.png
          11 kB
          Luca Bösch
        3. Verified MDL-61732.PNG
          3 kB
          Gladys Basiana

          Issue Links

            Activity

              People

              Assignee:
              phish108 Christian Glahn
              Reporter:
              lucaboesch Luca Bösch
              Peer reviewer:
              Jan Dageförde Jan Dageförde
              Integrator:
              Jake Dallimore Jake Dallimore
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 8 minutes
                  8m