Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61770

GeoIP has moved (again)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.11, 3.2.8, 3.3.5, 3.4.2, 3.5
    • Fix Version/s: 3.1.12, 3.2.9, 3.3.6, 3.4.3
    • Component/s: General
    • Labels:

      Description

      IPV6 lookup has started failing:

      1) core_iplookup_geoip_testcase::test_ipv6
      Coordinates are out of accepted tolerance
      Failed asserting that -118.4362 matches expected -118.2987.
       
      /var/www/html/iplookup/tests/geoip_test.php:104
      /var/www/html/lib/phpunit/classes/advanced_testcase.php:80
      

      I'm tempted to suggest that we should switch our unit tests away from being an exact match to just a type:

      • City should be a string,
      • Country should be a string
      • Both parts of the title should be a string
      • Latitude should be a float
      • Longitude should be a float

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dobedobedoh Andrew Nicols
                Reporter:
                dobedobedoh Andrew Nicols
                Peer reviewer:
                Jun Pataleta
                Integrator:
                Jake Dallimore
                Tester:
                CiBoT
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  17/May/18