Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 3.3.5, 4.4.6, 4.5.2
Component/s: Accessibility, Forms Library
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_33_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.4 Branch:
~~MDL-61823~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-61823-404
Pull 4.5 Branch:
~~MDL-61823~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-61823-405
Pull Main Branch:
~~MDL-61823~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-61823
Testing Instructions:
Hide

Navigate to course question bank

Add a new Essay question type

Set Response options > Allow attachments to "1"

Click on Accepted file types

Confirm the Accepted file types text input element is focused

Confirm there is only one Accepted file types element label
Show
Navigate to course question bank Add a new Essay question type Set Response options > Allow attachments to "1" Click on Accepted file types Confirm the Accepted file types text input element is focused Confirm there is only one Accepted file types element label
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-61823~~ using repository: https://github.com/paulholden/moodle/

MOODLE_404_STABLE (0 errors / 6 warnings) [branch: MDL-61823-404 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/6), gherkin (0/0),

MOODLE_405_STABLE (0 errors / 6 warnings) [branch: MDL-61823-405 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/6), gherkin (0/0),

main (0 errors / 6 warnings) [branch: MDL-61823 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/6), gherkin (0/0),

Should these errors be fixed?

Built on: Thu Apr 3 14:59:10 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-61823 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 6 warnings) [branch: MDL-61823-404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/6) , gherkin (0/0) , MOODLE_405_STABLE (0 errors / 6 warnings) [branch: MDL-61823-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/6) , gherkin (0/0) , main (0 errors / 6 warnings) [branch: MDL-61823 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/6) , gherkin (0/0) , Should these errors be fixed? Built on: Thu Apr 3 14:59:10 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-61823~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18913/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64756/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64757/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64758/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-61823~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18914/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64759/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64760/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64761/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-61823~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18915/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64762/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64763/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64764/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64765/ App tests (stable app version) / complete)

Built on: Thu Apr 3 14:39:33 UTC 2025
Show
Launching automatic jobs for branch MDL-61823 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18913/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64756/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64757/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64758/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-61823 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18914/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64759/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64760/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64761/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-61823 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18915/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64762/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64763/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64764/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64765/ App tests (stable app version) / complete) Built on: Thu Apr 3 14:39:33 UTC 2025

This is easiest to reproduce in th essay question type form:

Create a course and go to the question bank.
Create a new essay question type
Expected:There should only be one "Accepted file types" label for that input element.
Actual: there are two, one of which as no for="" attribute.

This can also be reproduced anywhere this element type is used, if you are accessing Moodle using a screen-reader.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-61823.png
244 kB
04/Apr/25 9:31 AM
MDL-61823-before.png
29 kB
06/Mar/20 5:04 PM

caused a regression

MDL-85139 invalid HTML because of duplicate element IDs

Closed

Discovered while testing

MDL-84752 Accessibility issues with missing form labels when adding essay question

Waiting for integration review

MDL-58411 File type restrictions for Quiz essay question type

Closed

has been marked as being related by

MDL-85169 Clicking on the label associated with the fieldset in core_form/element-group template does not move the focus

Open

is a regression caused by

MDL-53240 Form element and admin setting type to choose file types and type groups

Closed

will be (partly) resolved by

MDL-85100 mforms groups labels not displayed for question types

Closed

(1 will be (partly) resolved by)

Assignee:: Paul Holden

Reporter:: Jun Pataleta

Peer reviewer:: Carlos Castillo

Integrator:: Shamim Rezaie

Tester:: Ron Carl Alfon Yu

Participants:: Carlos Castillo, CiBoT, Jake Dallimore, Jun Pataleta, Luca Bösch, Paul Holden, Ron Carl Alfon Yu, Shamim Rezaie, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 15 Start watching this issue

Created:: 03/Apr/18 7:57 AM

Updated:: 11/Apr/25 3:47 PM

Resolved:: 04/Apr/25 11:43 PM

Estimated:

Remaining:

Logged:

2h 24m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify