Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61859

Completion unit tests are broken

    XMLWordPrintable

    Details

      Description

      https://github.com/moodle/moodle/blob/master/completion/tests/externallib_test.php#L295

      The test_override_activity_completion_status test calls expectException, several times... but there's no way that the exceptions after the first failure will work.

      There's probably other examples in Moodle.
      Perhaps we need a code sniff.

        Attachments

          Activity

            People

            • Assignee:
              jaked Jake Dallimore
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Mark Johnson
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze, Juan Leyva, Jake Dallimore, Jun Pataleta, Ryan Wyllie
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18