Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61880

Oauth2 field mappings are reset and endpoints lost when identity issuer settings saved

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MDL-61880-oauth2-field-mappings
    • Hide
      User field mappings:
      1. Create a Google OAuth 2 service
      2. Once you're back to the "OAuth 2 services" page, click the "Configure user field mappings" icon
      3. Confirm that the default user field mappings have been created.
      4. Edit the "given_name" field mapping. Set its "Internal field name" value to "firstnamephonetic".
      5. Create an additional user field mapping with the following values:
        External field name name
        Internal field name lastnamephonetic
      6. Go back to the "OAuth 2 services" page
      7. Edit the Google OAuth 2 service. Without changing anything, save the changes.
      8. Go back to the "User field mappings for issuer: Google" page.
      9. Confirm that the changes that you did for "given_name" and the new mapping "name" have been retained.
      Show
      User field mappings: Create a Google OAuth 2 service Once you're back to the " OAuth 2 services " page, click the " Configure user field mappings " icon Confirm that the default user field mappings have been created. Edit the " given_name " field mapping. Set its " Internal field name " value to " firstnamephonetic ". Create an additional user field mapping with the following values: External field name name Internal field name lastnamephonetic Go back to the " OAuth 2 services " page Edit the Google OAuth 2 service. Without changing anything, save the changes. Go back to the " User field mappings for issuer: Google " page. Confirm that the changes that you did for " given_name " and the new mapping " name " have been retained.

    Description

      When custom oauth2 service (tried with predefined Google service) is setup and then one or more user field mappings for this service is changed from default and then service is modified (scope added or anything else). This user field (and all others) are reset to defaults.

      When editing and saving a custom OAuth2 identity issuer's settings, all endpoints are deleted and have to be re-created each time.

      The loss of data here is lost configuration settings. Not everyone has good documentation that they can refer to in order to re-create the lost settings.

      Once the settings are lost due to this bug, users can no longer log into the site.

      The expectation is that these fields and endpoints should be preserved once created unless you are actually editing them.

      Attachments

        1. emptyspaces.png
          emptyspaces.png
          118 kB
        2. image-2020-03-12-13-07-45-105.png
          image-2020-03-12-13-07-45-105.png
          6 kB
        3. image-2020-03-12-13-47-08-485.png
          image-2020-03-12-13-47-08-485.png
          23 kB
        4. image-2021-11-26-11-51-09-481.png
          image-2021-11-26-11-51-09-481.png
          15 kB
        5. image-2021-11-26-11-51-36-638.png
          image-2021-11-26-11-51-36-638.png
          39 kB
        6. MDL-61880_master_1.png
          MDL-61880_master_1.png
          71 kB
        7. MDL-61880_master_2.png
          MDL-61880_master_2.png
          78 kB
        8. MDL-61880_v311_1.png
          MDL-61880_v311_1.png
          82 kB
        9. MDL-61880_v311_2.png
          MDL-61880_v311_2.png
          87 kB
        10. MDL-61880_v400_1.png
          MDL-61880_v400_1.png
          61 kB
        11. MDL-61880_v400_2.png
          MDL-61880_v400_2.png
          77 kB

        Issue Links

          Activity

            People

              yannickforget Yannick Forget
              mastnym Martin Mastny
              Michael Milette Michael Milette
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Angelia Dela Cruz Angelia Dela Cruz
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              7 Vote for this issue
              Watchers:
              18 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Nov/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 5 hours, 44 minutes
                  2d 5h 44m