Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61894

Tag managing dialog modals have unstyled buttons

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.3.6, 3.4.3, 3.5
    • 3.4.4, 3.5.1
    • Tags
    • MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MDL-61894-master
    • Hide

      Note: Test on Boost and Clean. Check only the buttons, ignore any bad layout in the modals. These will be addressed in
      MDL-62746.

      1. Go to Site Administration → Appearance → Manage tags.
      2. Click "Add tag collection".
      3. Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out.
      4. Cancel.
      5. Click "Default collection".
      6. Click "Add standard tags".
      7. Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out.
      8. Enter into the field 'Tag 1, Tag 2'.
      9. Click 'Continue'.
      10. Click the checkboxes of the two just inserted labels.
      11. Click "Combine selected".
      12. Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out.
      Show
      Note : Test on Boost and Clean. Check only the buttons, ignore any bad layout in the modals. These will be addressed in MDL-62746 . Go to Site Administration → Appearance → Manage tags. Click "Add tag collection". Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out. Cancel. Click "Default collection". Click "Add standard tags". Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out. Enter into the field 'Tag 1, Tag 2'. Click 'Continue'. Click the checkboxes of the two just inserted labels. Click "Combine selected". Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out.

    Description

      Some buttons look pretty old style.

      • Go to Site Administration → Appearance → manage tags (tag/manage.php).
      • Click "Add tag collection".
      • The "Add tag collection" dialog has unstyled buttons.
      • Cancel.
      • Click "Default collection".
      • Click "Add standard tags".
      • The "Add standard tags" dialog has unstyled buttons.
      • Add two comma separated labels (we will use them later).
      • Save.
      • Click the checkboxes of the two just inserted labels.
      • Click "Combine selected".
      • The "Combine selected" dialog has unstyled buttons.

      Attachments

        1. MDL-61894-1-after.png
          MDL-61894-1-after.png
          91 kB
        2. MDL-61894-1-before.png
          MDL-61894-1-before.png
          92 kB
        3. MDL-61894-2-after.png
          MDL-61894-2-after.png
          106 kB
        4. MDL-61894-2-before.png
          MDL-61894-2-before.png
          99 kB
        5. MDL-61894-3-after.png
          MDL-61894-3-after.png
          107 kB
        6. MDL-61894-3-before.png
          MDL-61894-3-before.png
          88 kB
        7. Verified_Add standard tags_Boost.PNG
          Verified_Add standard tags_Boost.PNG
          7 kB
        8. Verified_Add standard tags_Clean.PNG
          Verified_Add standard tags_Clean.PNG
          10 kB
        9. Verified_Add tag collection_Boost.PNG
          Verified_Add tag collection_Boost.PNG
          7 kB
        10. Verified_Add tag collection_Clean.PNG
          Verified_Add tag collection_Clean.PNG
          10 kB
        11. Verified_Combine selected_Boost.PNG
          Verified_Combine selected_Boost.PNG
          9 kB
        12. Verified_Combine selected_Clean.PNG
          Verified_Combine selected_Clean.PNG
          11 kB

        Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-61922 Bootstrap classes to dialogues to insert link, image and media in atto

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-62234 Review atto dialogs for better Boost display

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-62746 The layout of the content of core_tag modals don't look okay in BS4 stable

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              lucaboesch Luca Bösch
              lucaboesch Luca Bösch
              Mark Nelson Mark Nelson
              Jun Pataleta Jun Pataleta
              Gladys Basiana Gladys Basiana
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Jul/18

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 25 minutes
                  25m