Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61894

Tag managing dialog modals have unstyled buttons

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.6, 3.4.3, 3.5
    • Fix Version/s: 3.4.4, 3.5.1
    • Component/s: Tags
    • Testing Instructions:
      Hide

      Note: Test on Boost and Clean. Check only the buttons, ignore any bad layout in the modals. These will be addressed in
      MDL-62746.

      1. Go to Site Administration → Appearance → Manage tags.
      2. Click "Add tag collection".
      3. Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out.
      4. Cancel.
      5. Click "Default collection".
      6. Click "Add standard tags".
      7. Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out.
      8. Enter into the field 'Tag 1, Tag 2'.
      9. Click 'Continue'.
      10. Click the checkboxes of the two just inserted labels.
      11. Click "Combine selected".
      12. Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out.
      Show
      Note : Test on Boost and Clean. Check only the buttons, ignore any bad layout in the modals. These will be addressed in MDL-62746 . Go to Site Administration → Appearance → Manage tags. Click "Add tag collection". Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out. Cancel. Click "Default collection". Click "Add standard tags". Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out. Enter into the field 'Tag 1, Tag 2'. Click 'Continue'. Click the checkboxes of the two just inserted labels. Click "Combine selected". Confirm the buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-61894-master

      Description

      Some buttons look pretty old style.

      • Go to Site Administration → Appearance → manage tags (tag/manage.php).
      • Click "Add tag collection".
      • The "Add tag collection" dialog has unstyled buttons.
      • Cancel.
      • Click "Default collection".
      • Click "Add standard tags".
      • The "Add standard tags" dialog has unstyled buttons.
      • Add two comma separated labels (we will use them later).
      • Save.
      • Click the checkboxes of the two just inserted labels.
      • Click "Combine selected".
      • The "Combine selected" dialog has unstyled buttons.

        Attachments

        1. MDL-61894-1-after.png
          91 kB
          Luca Bösch
        2. MDL-61894-1-before.png
          92 kB
          Luca Bösch
        3. MDL-61894-2-after.png
          106 kB
          Luca Bösch
        4. MDL-61894-2-before.png
          99 kB
          Luca Bösch
        5. MDL-61894-3-after.png
          107 kB
          Luca Bösch
        6. MDL-61894-3-before.png
          88 kB
          Luca Bösch
        7. Verified_Add standard tags_Boost.PNG
          7 kB
          Gladys Basiana
        8. Verified_Add standard tags_Clean.PNG
          10 kB
          Gladys Basiana
        9. Verified_Add tag collection_Boost.PNG
          7 kB
          Gladys Basiana
        10. Verified_Add tag collection_Clean.PNG
          10 kB
          Gladys Basiana
        11. Verified_Combine selected_Boost.PNG
          9 kB
          Gladys Basiana
        12. Verified_Combine selected_Clean.PNG
          11 kB
          Gladys Basiana

          Issue Links

            Activity

              People

              Assignee:
              lucaboesch Luca Bösch
              Reporter:
              lucaboesch Luca Bösch
              Peer reviewer:
              Mark Nelson Mark Nelson
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/18

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 25 minutes
                  25m