Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-61908

Same heading appearing twice on Data privacy pages

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.5, 3.4.2, 3.5.2, 3.6
    • Fix Version/s: 3.3.9, 3.4.6, 3.5.3
    • Component/s: Privacy, Themes
    • Labels:
    • Testing Instructions:
      Hide

      Test in Boost and Clean.

      1. Login as Admin.
      2. Go to Site administration > Users.
      3. Go to each data privacy page in the Site administration.
        1. 'Data requests' (admin/tool/dataprivacy/datarequests.php)
        2. 'Data registry' (admin/tool/dataprivacy/dataregistry.php)
          1. Set defaults (admin/tool/dataprivacy/defaults.php)
          2. Edit categories (admin/tool/dataprivacy/categories.php)
          3. Edit purposes (admin/tool/dataprivacy/purposes.php)
        3. 'Data deletion' (admin/tool/dataprivacy/datadeletion.php)
        4. 'Plugin privacy registry' (admin/tool/dataprivacy/pluginregistry.php)
      4. For each page make sure the main heading displays the site's name and not the page title. The page title is displayed as a page heading in the content area. 
      5. Go to Site administration > Users > Data requests.
      6. Click on the "New request" button.
        1. make sure the page heading is "Create a new data request".
      7. Login as a PO (https://docs.moodle.org/35/en/Privacy_officer_role).  
      8. Go to Site administration > Users > Privacy and policies > Data requests.
      9. Make sure the main heading displays the site's name and not the page title.
      Show
      Test in Boost and Clean. Login as Admin. Go to Site administration > Users. Go to each data privacy page in the Site administration. 'Data requests' (admin/tool/dataprivacy/datarequests.php) 'Data registry' (admin/tool/dataprivacy/dataregistry.php) Set defaults (admin/tool/dataprivacy/defaults.php) Edit categories (admin/tool/dataprivacy/categories.php) Edit purposes (admin/tool/dataprivacy/purposes.php) 'Data deletion' (admin/tool/dataprivacy/datadeletion.php) 'Plugin privacy registry' (admin/tool/dataprivacy/pluginregistry.php) For each page make sure the main heading displays the site's name and not the page title. The page title is displayed as a page heading in the content area.   Go to Site administration > Users > Data requests. Click on the "New request" button. make sure the page heading is "Create a new data request". Login as a PO ( https://docs.moodle.org/35/en/Privacy_officer_role ).   Go to Site administration > Users > Privacy and policies > Data requests. Make sure the main heading displays the site's name and not the page title.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Epic Link:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-61908-master
    • Sprint:
      GDPR Followup Sprint 1

      Description

      Multiple pages in the Data privacy (tool_dataprivacy) plugin have the same heading displayed twice.

      This is because these page set the same text by both $PAGE->set_heading() and echo $OUTPUT->heading($title);. It is common that pages like this should use

      $PAGE->set_heading($SITE->fullname);
      

      instead.

        Attachments

        1. boost.PNG
          boost.PNG
          175 kB
        2. clean.PNG
          clean.PNG
          145 kB
        3. screenshot-1.png
          screenshot-1.png
          38 kB

          Activity

            People

            Assignee:
            Geshoski Mihail Geshoski
            Reporter:
            mudrd8mz David Mudrák (@mudrd8mz)
            Peer reviewer:
            Jun Pataleta
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Nov/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour
                1h