[MDL-61908] Same heading appearing twice on Data privacy pages - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.3.5, 3.4.2, 3.5.2, 3.6
Fix Version/s: 3.3.9, 3.4.6, 3.5.3
Component/s: Privacy, Themes
Labels:
- ci

Testing Instructions:
Hide

Test in Boost and Clean.

Login as Admin.

Go to Site administration > Users.

Go to each data privacy page in the Site administration.

'Data requests' (admin/tool/dataprivacy/datarequests.php)

'Data registry' (admin/tool/dataprivacy/dataregistry.php)

Set defaults (admin/tool/dataprivacy/defaults.php)

Edit categories (admin/tool/dataprivacy/categories.php)

Edit purposes (admin/tool/dataprivacy/purposes.php)

'Data deletion' (admin/tool/dataprivacy/datadeletion.php)

'Plugin privacy registry' (admin/tool/dataprivacy/pluginregistry.php)

For each page make sure the main heading displays the site's name and not the page title. The page title is displayed as a page heading in the content area.

Go to Site administration > Users > Data requests.

Click on the "New request" button.

make sure the page heading is "Create a new data request".

Login as a PO (https://docs.moodle.org/35/en/Privacy_officer_role).

Go to Site administration > Users > Privacy and policies > Data requests.

Make sure the main heading displays the site's name and not the page title.
Show
Test in Boost and Clean. Login as Admin. Go to Site administration > Users. Go to each data privacy page in the Site administration. 'Data requests' (admin/tool/dataprivacy/datarequests.php) 'Data registry' (admin/tool/dataprivacy/dataregistry.php) Set defaults (admin/tool/dataprivacy/defaults.php) Edit categories (admin/tool/dataprivacy/categories.php) Edit purposes (admin/tool/dataprivacy/purposes.php) 'Data deletion' (admin/tool/dataprivacy/datadeletion.php) 'Plugin privacy registry' (admin/tool/dataprivacy/pluginregistry.php) For each page make sure the main heading displays the site's name and not the page title. The page title is displayed as a page heading in the content area. Go to Site administration > Users > Data requests. Click on the "New request" button. make sure the page heading is "Create a new data request". Login as a PO ( https://docs.moodle.org/35/en/Privacy_officer_role ). Go to Site administration > Users > Privacy and policies > Data requests. Make sure the main heading displays the site's name and not the page title.
Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
Epic Link:
GDPR Followups
Pull from Repository:
git://github.com/mihailges/moodle.git
Pull 3.5 Branch:
~~MDL-61908~~-35
Pull 3.5 Diff URL:
https://github.com/mihailges/moodle/compare/9c1fc95578...MDL-61908-35
Pull Master Branch:
~~MDL-61908~~-master
Pull Master Diff URL:
https://github.com/mihailges/moodle/compare/674ef9baac...MDL-61908-master

Sprint:
GDPR Followup Sprint 1

Description

Multiple pages in the Data privacy (tool_dataprivacy) plugin have the same heading displayed twice.

This is because these page set the same text by both $PAGE->set_heading() and echo $OUTPUT->heading($title);. It is common that pages like this should use

$PAGE->set_heading($SITE->fullname);

instead.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

boost.PNG
175 kB
19/Sep/18 9:11 AM
clean.PNG
145 kB
19/Sep/18 9:11 AM
screenshot-1.png
38 kB
10/Apr/18 3:42 AM

Activity

People

Assignee:: Mihail Geshoski

Reporter:: David Mudrák (@mudrd8mz)

Peer reviewer:: Jun Pataleta

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: CiBoT, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Janelle Barcega, Jun Pataleta, Mihail Geshoski

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 10/Apr/18 3:42 AM

Updated:: 28/Sep/18 9:53 AM

Resolved:: 21/Sep/18 12:31 AM

Fix Release Date:: 12/Nov/18

Time Tracking

Estimated:

Remaining:

Logged: