Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62011

Approval of a course request fails

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.5, 3.4.2, 3.5
    • Fix Version/s: 3.3.6, 3.4.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Testinstruction

      1. Activate the setting "enablecourserequests".
      2. Login as a non admin user.
      3. Go to <your-moodle>/course/request.php.
      4. Fill in all the needed information and memorize the chosen shortname.
      5. Post this request.
      6. Login as Admin or as a user who can approve course requests.
      7. Create a new course manually with the shortname you memorized before.
      8. Go to <your-moodle>/course/pending.php.
      9. Look out for the made request and click on the button "Approve"
      10. The course has been created and the edit form appears.
      11. In the edit form the shortname has been extended by a counter and the fullname by the localized word "copy"
      Show
      Testinstruction Activate the setting "enablecourserequests". Login as a non admin user. Go to <your-moodle>/course/request.php. Fill in all the needed information and memorize the chosen shortname. Post this request. Login as Admin or as a user who can approve course requests. Create a new course manually with the shortname you memorized before. Go to <your-moodle>/course/pending.php. Look out for the made request and click on the button "Approve" The course has been created and the edit form appears. In the edit form the shortname has been extended by a counter and the fullname by the localized word "copy"
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip_MDL-62011_master_approval_of_course_request

      Description

      If someone has requested a new course with shortname "xyz" and after that but before the aproval a course was created manually with the same shortname "xyz" the approval fails with an error.

      Testinstruction

      1. Activate the setting "enablecourserequests".
      2. Login as a non admin user.
      3. Go to <your-moodle>/course/request.php.
      4. Fill in all the needed information and memorize the chosen shortname.
      5. Post this request.
      6. Login as Admin or as a user who can approve course requests.
      7. Create a new course manually with the shortname you memorized before.
      8. Go to <your-moodle>/course/pending.php.
      9. Look out for the made request and click on the button "Approve"
      10. The error message appears and the script stops.

        Attachments

        1. Capture.PNG
          Capture.PNG
          44 kB
        2. MDL-62011.png
          MDL-62011.png
          186 kB

          Activity

            People

            Assignee:
            grabs Andreas Grabs
            Reporter:
            grabs Andreas Grabs
            Peer reviewer:
            Luca Bösch
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              17/May/18

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 36 minutes
                36m