Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62017

In language customisation interface, buttons are not styled

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.5, 3.4.3, 3.5
    • Fix Version/s: 3.4.4, 3.5.1
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide

      Note: Test on Boost and Clean.

      1. Log in as admin.
      2. Go to Site administration → Language → Language customisation.
      3. Choose a language, then click "Open language pack for editing", followed by "Continue".
      4. Highlight moodle.php in "Show strings of these components", click "Show strings".
      5. Confirm the "Apply changes and continue editing" and the "Save changes to the language pack" buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out.
      6. Scroll at the bottom of the page.
      7. Confirm the "Apply changes and continue editing" and the "Save changes to the language pack" buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out.
      8. Reduce the width of the page.
      9. Confirm that the buttons are neatly stacked on top of each other and centred. (In Boost, you might notice a lack of spacing between the buttons when they are stacked together, but this is fine)
      Show
      Note : Test on Boost and Clean. Log in as admin. Go to Site administration → Language → Language customisation. Choose a language, then click "Open language pack for editing", followed by "Continue". Highlight moodle.php in "Show strings of these components", click "Show strings". Confirm the "Apply changes and continue editing" and the "Save changes to the language pack" buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out. Scroll at the bottom of the page. Confirm the "Apply changes and continue editing" and the "Save changes to the language pack" buttons are styled consistently with the Bootstrap buttons (For Boost, check this out. For Clean, check this out. Reduce the width of the page. Confirm that the buttons are neatly stacked on top of each other and centred. (In Boost, you might notice a lack of spacing between the buttons when they are stacked together, but this is fine)
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-62017-master

      Description

      Both the "Apply changes and continue editing" and the "Save changes to the language pack" buttons lack the appropriate classes and look 90ies style.

      To reproduce:

      • Log in as admin.
      • Go to Site administration → Language → Language customisation.
      • Choose a language, then click "Open language pack for editing", followed by "Continue".
      • Highlight moodle.php in "Show strings of these components", klick "Show strings".

        Attachments

        1. MDL-62017.xlsx
          7.87 MB
        2. MDL-62017-after.png
          MDL-62017-after.png
          62 kB
        3. MDL-62017-before.png
          MDL-62017-before.png
          61 kB

          Activity

            People

            Assignee:
            lucaboesch Luca Bösch
            Reporter:
            lucaboesch Luca Bösch
            Peer reviewer:
            Mark Nelson
            Integrator:
            Jun Pataleta
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            cameron1729, David Mudrák (@mudrd8mz), Helen Foster
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Jul/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m