Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62034

User Tours: Reset-Link appears on assignment grading page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5, 3.6.5, 3.7.1
    • Fix Version/s: 3.6.6, 3.7.2
    • Component/s: User Tours
    • Labels:

      Description

      Hi,
      we've created a user tour for our users that should pop up on activity pages:
      /mod/%/view.php

      The grading page is not called with an own URL, but it is used with the assignment url and the grading parameter (mod/assign/view.php?id=12345&action=grader).

      This is why the tour is matching the URL and the link to reset is integrated on the page. The problem is that on this page, there's no footer and in our case the code is being intserted between several <javascript> tags and it also contains an empty link:

      <div class="usertour">
          <a href="#" data-action="tool_usertours/resetpagetour">Reset user tour</a>
      </div>
      

      The result looks like this:

      Steps to reproduce:

      • Login as Admin
      • Go to the user tours page (/admin/tool/usertours/configure.php)
      • Import the attached user tour
      • Login as a teacher and open a course
      • Turn editing on
      • Create a new Assignment with a title and default values
      • Save and display
      • Click the button "Grade"
      • See the result: A link to reset the user tour is displayed in the top left corner and overlaps the navigation links. Furthermore the reset user tour link is not clickable (due to href=#).

      Best, Kathrin

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              kosswa Kathrin Osswald
              Peer reviewer:
              Andrew Nicols
              Integrator:
              Jun Pataleta
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 45 minutes
                  45m