Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62035

core_comment implementation does not handle deletion correctly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.3.5, 3.4.2, 3.5
    • Fix Version/s: 3.3.6, 3.4.3
    • Component/s: Comments, Privacy
    • Labels:

      Description

      Generally speaking when data is deleted for a context, all comments are deleted.
      However comments are stored with:

      1. contextid
      2. component
      3. area
      4. itemid

      These are already used for the export, but only the contextid is used in the deletion.

      Although, in most cases, when deleting for one context you'll delete all comments, this must not be assumed. There can be legitimate reasons to keep data from comments.

      One example:
      The tool_privacy tool may allow for comments relating to a delete request. These comments form part of the response and there is a strong business reason not to delete the comments.

      We must update the comments provider to take more than just contextid for deletion.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Ryan Wyllie
              Integrator:
              Andrew Nicols
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 15 minutes
                  15m