Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62147

Make sure every table in lib/db/install.xml has a core subsystem responsible for it

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.3.5, 3.4.2
    • Fix Version/s: 3.3.6, 3.4.3
    • Component/s: Privacy
    • Labels:
    • Testing Instructions:
      Hide

      For testing on 3.3 and 3.4 you need to install tool_dataprivacy first
      Create DPO role and assign it to somebody (admin is ok)

      Test 1. Manual portfolio export

      1. Enable portfolios and some portfolio (for example file download)
      2. As a user post on a forum, add attachment, download it to your portfolio
      3. Request your data to be exported and approve it as DPO
      4. Inspect the export file and make sure the portfolio logs were exported

      Test 2. Scales

      1. With a few user accounts (manager):
        • Create scales at the system context
        • Create scales in a course
        • Modify the above scales
        • Delete some of the scales
      2. Export the data of some of these users
      3. Confirm that the exported data contains a record of the user editing/deleting the scales in 'System > Grades > Related to me' and 'Course name > Grades > Related to me'
      Show
      For testing on 3.3 and 3.4 you need to install tool_dataprivacy first Create DPO role and assign it to somebody (admin is ok) Test 1. Manual portfolio export Enable portfolios and some portfolio (for example file download) As a user post on a forum, add attachment, download it to your portfolio Request your data to be exported and approve it as DPO Inspect the export file and make sure the portfolio logs were exported Test 2. Scales With a few user accounts (manager): Create scales at the system context Create scales in a course Modify the above scales Delete some of the scales Export the data of some of these users Confirm that the exported data contains a record of the user editing/deleting the scales in 'System > Grades > Related to me' and 'Course name > Grades > Related to me'
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull Master Branch:
      wip-MDL-62147-master-4

      Description

      When we go through the list of core subsystems we may accidentally "forget" some database tables that have user data because there is no strict relation table<->component

      Go through all tables defined in lib/db/install.xml that may have user data and make sure it is covered by one of the core components

      There are a few places where we have specifically excluded the tables.
      Nevertheless, we should probably describe the table in metadata.

      Table Field Decision Issue
      config_log userid TODO core MDL-62425
      upgrade_log userid TODO core MDL-62425
      my_pages userid Specifically excluded but should we add metadata? MDL-62147
      user_preferences userid TODO core MDL-62147
      scale userid Needs to be done in core_grade MDL-62147
      scale_history loggeduser, userid Needs to be done in core_grade MDL-62147
      role_sortorder userid Needs to be done in core_role MDL-62147
      events_queue userid TODO MDL-62425
      grade_import_newitem importer Temporary tables only MDL-62147
      grade_import_values importer, userid Temporary tables only MDL-62147
      portfolio_log userid TODO - needs exporting MDL-62147
      portfolio_tempdata userid TODO MDL-62147
      backup_controllers userid Already done N/A
      grading_instances raterid Already done N/A
      task_adhoc userid TODO core MDL-62425
      chat_messages_current userid TODO MDL-62147
      chat_users userid TODO MDL-62147
      forum_queue userid TODO MDL-62147
      enrol_flatfile userid TODO MDL-62426
      enrol_lti_users userid Already done N/A
      block_recent_activity userid TODO MDL-62147
      tool_policy_versions usermodified TODO MDL-62433
      logstore_standard_log userid Incorrect name MDL-62147

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  17/May/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours
                  2h