Moodle
  1. Moodle
  2. MDL-6216

Course category totals include hidden courses

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.7, 1.7.1, 1.7.2, 1.7.3, 1.8, 1.8.1, 1.8.2, 1.8.3, 1.9, 2.0
    • Fix Version/s: 1.9, 2.0
    • Component/s: Other
    • Labels:
      None
    • Environment:
      All
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Rank:
      28444

      Description

      The course category view of the Moodle homepage (i.e. for students who haven't joined a course yet, or have called up the full list) includes a total of courses available in each category / subcategory.

      This count includes hidden course pages, which is potentially confusing for users. Could hidden pages be excluded from the count?

        Activity

        Hide
        Jenny Gray added a comment -

        I know I theoretically have checkin rights to CVS, but I'm not sure how to use them, so I thought I'd post a diff here instead to be on the safe side.

        The attached patch fixes this bug when applied to 1.7 STABLE (tested from 20 Oct download).

        Show
        Jenny Gray added a comment - I know I theoretically have checkin rights to CVS, but I'm not sure how to use them, so I thought I'd post a diff here instead to be on the safe side. The attached patch fixes this bug when applied to 1.7 STABLE (tested from 20 Oct download).
        Hide
        Jenny Gray added a comment -

        I've retested and found that the bug still exists in Moodle 2.0 and my patch still fixes it. I'm braver about commits these days! So I'll commit to 1.9 branch and HEAD.

        Show
        Jenny Gray added a comment - I've retested and found that the bug still exists in Moodle 2.0 and my patch still fixes it. I'm braver about commits these days! So I'll commit to 1.9 branch and HEAD.
        Hide
        Martin Dougiamas added a comment -

        Thanks!

        Show
        Martin Dougiamas added a comment - Thanks!
        Hide
        Martin Dougiamas added a comment -

        Please don't forget to move the MOODLE_19_MERGED tag as well. This indicates to everyone that the changes were merged back to head from the branch.

        I've done it for this file.

        cd moodle/19/course
        cvs tag -F MOODLE_19_MERGED lib.php

        Show
        Martin Dougiamas added a comment - Please don't forget to move the MOODLE_19_MERGED tag as well. This indicates to everyone that the changes were merged back to head from the branch. I've done it for this file. cd moodle/19/course cvs tag -F MOODLE_19_MERGED lib.php
        Hide
        Jenny Gray added a comment -

        Oops sorry - I always forget that bit

        Thanks for doing it for me.

        Show
        Jenny Gray added a comment - Oops sorry - I always forget that bit Thanks for doing it for me.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: