Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62171

Modal title focus only on text

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.5
    • Component/s: Themes
    • Labels:

      Description

      A little while ago we changed the modal title to take up the full height of the header so that the blue focus outline appeared to surround the modal header rather than just the words within the header. It was purely an aesthetic change.

      Unfortunately we can't remove the focus outline altogether because of accessibility reasons and additionally when the modal opens it's required to focus on something reasonable (which is why we chose the header).

      It looks like as part of the upgrade the title element has been returned to regular size which is causing the focus outline to appear only around the text again.

      There may be a better way to fix this than to add some custom CSS to have the modal title fill the modal header (the previous solution).

      This is what it used to look like:

      And what it looks like now:

      Steps to reproduce:

      1. Log in as admin
      2. Navigate to the calendar
      3. Click on the "new event" button
      4. See the new event modal appear and the text "New event" is given focus (has the blue outline)

        Attachments

        1. 62171_ss.png
          62171_ss.png
          110 kB
        2. after.png
          after.png
          91 kB
        3. before.png
          before.png
          72 kB

          Issue Links

            Activity

              People

              • Assignee:
                basbrands Bas Brands
                Reporter:
                ryanwyllie Ryan Wyllie
                Peer reviewer:
                Ryan Wyllie
                Integrator:
                Andrew Nicols
                Tester:
                Andrew Nicols
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  17/May/18