Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62180

Activity navigation distinctive class to address, e.g. in print

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Navigation
    • Labels:
    • Testing Instructions:
      Hide

      Please test in clean and boost

      1. Create a course and create three assignment activities in a section.
      2. View the middle assignment by clicking its name on the course home page.
      3. Verify the activity navigation (the left and right arrows pointing to the previous and next activities at the bottom of the page) still looks the same as before.
      4. Using your browser's DOM inspection tools, check the activity navigation div and verify it now has class "activity-navigation" in addition to the previous m-t-2 and m-b-1 (it'll be the wrapper div with class="m-t-2 m-b-1 activity-navigation").
      Show
      Please test in clean and boost Create a course and create three assignment activities in a section. View the middle assignment by clicking its name on the course home page. Verify  the activity navigation (the left and right arrows pointing to the previous and next activities at the bottom of the page) still looks the same as before. Using your browser's DOM inspection tools, check the activity navigation div and verify  it now has class "activity-navigation" in addition to the previous m-t-2 and m-b-1 (it'll be the wrapper div with class="m-t-2 m-b-1 activity-navigation").
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-62180-master
    • Pull Master Diff URL:

      Description

      I believe the activity navigation div should have an distinctive class applied, not just

      <div class="m-t-2 m-b-1">

      as it is as of now.

      Then, for example, it could be excluded by print stylesheets.

      Now, in every page you give out by the media of print, there's the activity navigation in it.

        Attachments

          Issue Links

          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-62375 Move interface code from renderer to the appropriate mustache template

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              lucaboesch Luca Bösch
              Reporter:
              lucaboesch Luca Bösch
              Peer reviewer:
              Adrian Greeve Adrian Greeve
              Integrator:
              Jake Dallimore Jake Dallimore
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 10 minutes
                  10m