Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62244

Link to mod_label redirects to the course, not to the label

    XMLWordPrintable

Details

    • MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_310_STABLE, MOODLE_39_STABLE
    • MDL-62244_39_label_view
    • MDL-62244_311_label_view
    • MDL-62244_master_label_view
    • Hide
      1. Login as Admin.
      2. Create a Course. Ensure that under "Course format", Format is set to Topics format and Course layout set to Show one section per page.
      3. Enroll a Student in the Course.
      4. Add a label to the course with an expected completion date sometime in the next week.
      5. Login as Student.
      6. Go to the Dashboard.
      7. Add a timeline block to the Dashboard if it isn't already there.
      8. Find the link to the label on the timeline block and click it.
        • Verify that you are taken directly to the section page with the label and scrolled down to where the label is on the page.
      Show
      Login as Admin. Create a Course. Ensure that under "Course format", Format is set to Topics format and Course layout set to Show one section per page. Enroll a Student in the Course. Add a label to the course with an expected completion date sometime in the next week. Login as Student. Go to the Dashboard. Add a timeline block to the Dashboard if it isn't already there. Find the link to the label on the timeline block and click it. Verify that you are taken directly to the section page with the label and scrolled down to where the label is on the page.

    Description

      If visiting a label directly, e.g. /mod/label/view.php?id=123 the view.php redirects to the course page. While not that common, it really should redirect to the label where possible.

      I'm not really sure if this is a bug or not, but I could see one scenario in which it is - if a user creates a label, marks it as needing completion and sets a date, it will naturally appear in the course overview as an outstanding task, but the 'view' link will not direct to the right place.

      In particular, if the course has a topics format, with sections on their own page, it's entirely possible the view link in this situation will end up pushing the user onto the wrong page (e.g. to the first page of a course where the label is in the second section)

      Happy to add a patch if that helps.

      Attachments

        Issue Links

          Activity

            People

              sheesania sheesania
              peter.spicer Peter Spicer
              Mihail Geshoski Mihail Geshoski
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Anna Carissa Sadia Anna Carissa Sadia
              Jake Dallimore, Mathew May, Mihail Geshoski
              Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/May/21

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 30 minutes
                  2h 30m