[MDL-62285] moodle_content_writer assumes context names will be unique to build context path - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.5
Fix Version/s: 3.3.6, 3.4.3
Component/s: Privacy
Labels:
- ci
- triaged

Affected Branches:
MOODLE_35_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE
Epic Link:
GDPR Subject Access Request System
Pull from Repository:
git://github.com/ryanwyllie/moodle.git
Pull Master Branch:
~~MDL-62285~~-master
Pull Master Diff URL:
https://github.com/ryanwyllie/moodle/compare/446d8483a3...MDL-62285-master
Testing Instructions:
Hide

Log in as admin

Set the theme to the Clean theme

View the dashboard

Hide (collapse) the “private files” block

Go to the profile page

user menu > profile

Add the “private files” block to this page

Dock the private files block

Download the attached testfinal.php script and run it from your moodle root directory to generate an export of the admin user data

Note: you may need to edit the script and set the user id to match the admin user id on your system

View the admin user context folder in the export (it should be System > User <admin user’s name>)

CONFIRM that there are two separate folders for “Block Private files” each with a different number at the end of the folder name
Show
Log in as admin Set the theme to the Clean theme View the dashboard Hide (collapse) the “private files” block Go to the profile page user menu > profile Add the “private files” block to this page Dock the private files block Download the attached testfinal.php script and run it from your moodle root directory to generate an export of the admin user data Note: you may need to edit the script and set the user id to match the admin user id on your system View the admin user context folder in the export (it should be System > User <admin user’s name>) CONFIRM that there are two separate folders for “Block Private files” each with a different number at the end of the folder name

Description

The moodle_content_writer::get_context_path() function uses the context name to build the path for the context however context names are not guaranteed to be unique, for example with blocks.

You can add two separate instances of the same block in the same context (for example one on the dashboard and one on the user profile page) which will result in the same path being generated for two separate block instances.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Step10_MDL-62285.PNG
9 kB
08/May/18 11:41 PM
Step9_MDL-62285.PNG
12 kB
08/May/18 11:41 PM
testfinal.php
1 kB
02/May/18 9:45 PM

Issue Links

Discovered while testing

MDL-62248 Implement core_privacy for core_block

Closed

has been marked as being related by

MDL-62240 Export fails if some of the paths has more than 255 characters

Closed

Activity

People

Assignee:: Ryan Wyllie

Reporter:: Ryan Wyllie

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Andrew Lyons

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, Ryan Wyllie, Sara Arjona (@sarjona)

Component watchers:: Andrew Lyons, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 01/May/18 9:50 PM

Updated:: 09/May/18 6:33 AM

Resolved:: 09/May/18 6:33 AM

Fix Release Date:: 17/May/18

Time Tracking

Estimated:

Remaining:

Logged:

30m