Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62294

php72 array/countable problem @ build_installed_themes_task

    XMLWordPrintable

Details

    • MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MDL-62294-master
    • Hide
      Prerequisite
      1. Server using PHP 7.2
      Test
      1. Download test_build_themes.php to your moodle root directory.
      2. Run it:

        php test_build_themes.php

      3. Run the task "core\task\build_installed_themes_task" master

        php admin/tool/task/cli/adhoc_task.php --execute=\\core\\task\\build_installed_themes_task
        

        3.5 and 3.4 just run cron.

      4. Confirm the task ends successfully.
      5. Confirm you don't get any PHP Warning message.
      Show
      Prerequisite Server using PHP 7.2 Test Download test_build_themes.php to your moodle root directory. Run it: php test_build_themes.php Run the task " core\task\build_installed_themes_task " master php admin/tool/task/cli/adhoc_task.php --execute=\\core\\task\\build_installed_themes_task 3.5 and 3.4 just run cron. Confirm the task ends successfully. Confirm you don't get any PHP Warning message.

    Description

      Was testing MDL-62167 when I saw this output with php72 while running php admin/cli/cron.php

      ...
      Execute adhoc task: core\task\build_installed_themes_task
      ... started 20:07:00. Current memory use 71.2MB.
      PHP Warning:  count(): Parameter must be an array or an object that implements Countable in /Users/stronk7/git_moodle/integration/lib/lessphp/Visitor/toCSS.php on line 113
       
      Warning: count(): Parameter must be an array or an object that implements Countable in /Users/stronk7/git_moodle/integration/lib/lessphp/Visitor/toCSS.php on line 113
      PHP Warning:  count(): Parameter must be an array or an object that implements Countable in /Users/stronk7/git_moodle/integration/lib/lessphp/Visitor/toCSS.php on line 113
       
      Warning: count(): Parameter must be an array or an object that implements Countable in /Users/stronk7/git_moodle/integration/lib/lessphp/Visitor/toCSS.php on line 113
      ... used 8 dbqueries
      ... used 40.387565135956 seconds
      Adhoc task complete: core\task\build_installed_themes_task
      ...
      

      Attachments

        Issue Links

          Activity

            People

              jpataleta Jun Pataleta
              stronk7 Eloy Lafuente (stronk7)
              Mark Nelson Mark Nelson
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Simey Lameze Simey Lameze
              Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Nov/18