[MDL-62319] iOS 11.3 broke Moodle assignment grading interface - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.3.5, 3.4.2, 3.6
Fix Version/s: 3.4.6, 3.5.3
Component/s: Assignment, JavaScript
Labels:
- CatalystIT
- ci
- partner
- release_notes
- triaged

Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Master Branch:
~~MDL-62319~~-master
Pull Master Diff URL:
https://github.com/damyon/moodle/compare/129783b98c...MDL-62319-master
Testing Instructions:
Hide

Grade Assignment Using iOS Devices, Chrome on mobile, some very old browser on mobile device (i.e. Samsung internet on Galaxy S5 from browserstack) and also desktop:

Create an assignment with PDF annotations enabled and some students enrolled

Login Moodle using an account which has grading permision .

Go to the assignment and grade a submission

Add these annotations: pen, line, rectangle, oval.

Expected result: the page is not moved when drawing these annotations

Try scrolling the page using the "hand" tool, make sure it scrolls
Show
Grade Assignment Using iOS Devices , Chrome on mobile, some very old browser on mobile device (i.e. Samsung internet on Galaxy S5 from browserstack) and also desktop: Create an assignment with PDF annotations enabled and some students enrolled Login Moodle using an account which has grading permision . Go to the assignment and grade a submission Add these annotations: pen, line, rectangle, oval. Expected result: the page is not moved when drawing these annotations Try scrolling the page using the "hand" tool, make sure it scrolls

Description

Similar to ~~MDL-62239~~, iOS 11.3 seems to have broken the Moodle assignment grading interface.

Quoting Moodle dev chat:

Alexander Bias, [03.05.2018, 09:24:40]:
Hey,
we are currently receiving incident reports that the Assignment grading interface (aka. Edit PDF) in Moodle 3.4 does not work anymore on iOS 11.3. Teachers trying to annotate a submission face the fact that they are dragging the canvas instead of drawing boxes / lines or writing hand-written text. I noticed ~~MDL-62239~~ which might have the same cause, but which only fixes DnD question types.
Can anyone confirm that Edit PDF is also broken on iOS 11.3?

Andrew Nicols Admin, [03.05.2018, 09:33:03]:
Hi Alex

I suspect it's the same cause

And ~~MDL-62239~~ links a webkit bug which is the likely root cause of both

Affecting a lot of people (https://bugs.webkit.org/show_bug.cgi?id=184250)

Unfortunately there hasn't been any update on webkit, and the Apple bug report is behind closed doors.

Attachments

Issue Links

has a non-specific relationship to

MDL-62239 iOS 11.3 broke Moodle drag-drop question types

Closed

is duplicated by

MDL-63353 assignment PDF annotation causes javascript error in Chrome

Closed

MDL-64721 Can't scroll assignment grading UI on iPad

Closed

Testing discovered

MDL-63492 Assignment grading interface: Dragging existing annotations might be stuttering and sluggish

Open

Activity

People

Assignee:: Damyon Wiese

Reporter:: Alexander Bias

Peer reviewer:: Marina Glancy

Integrator:: Eloy Lafuente (stronk7)

Tester:: Anna Carissa Sadia

Participants:: Alexander Bias, Anna Carissa Sadia, CiBoT, Cristian Alvarado, Damyon Wiese, Eloy Lafuente (stronk7), Garry Edmonds, Jari Vilkman, Marina Glancy, Nathan Nguyen

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 14 Vote for this issue

Watchers:: 19 Start watching this issue

Dates

Created:: 04/May/18 12:01 AM

Updated:: 31/May/19 5:22 PM

Resolved:: 17/Oct/18 12:02 AM

Fix Release Date:: 12/Nov/18

Time Tracking

Estimated:

Remaining:

Logged:

1h 30m