Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62322

Boostrap 4 migration, hidden-* classes in the boost theme

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.5
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Test footer flat menu visibility:

      1. Login as admin.
      2. Navigate to Site administration > Appearance > Theme Settings.
      3. Copy the custom menu example for form field "Custom menu items" into the form field text area.
      4. Navigate home.
      5. Verify custom menu items are visible.
      6. Reduce / increase the browser size.
      7. Verify the custom menu items disappear from the navbar on smaller browser sizes. When hidden in navbar the menu items should be visible in the site footer.

      Test hidden print 

      1. Login as any user, it does not matter what role you have.
      2. Navigate to any page that has a block area, often courses have a block area.
      3. Print preview the page (don't waste any paper!)
      4. The block area contents should not be visible on print.
      Show
      Test footer flat menu visibility: Login as admin. Navigate to Site administration > Appearance > Theme Settings. Copy the custom menu example for form field "Custom menu items" into the form field text area. Navigate home. Verify custom menu items are visible. Reduce / increase the browser size. Verify the custom menu items disappear from the navbar on smaller browser sizes. When hidden in navbar the menu items should be visible in the site footer. Test hidden print  Login as any user, it does not matter what role you have. Navigate to any page that has a block area, often courses have a block area. Print preview the page (don't waste any paper!) The block area contents should not be visible on print.
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-62322-master
    • Pull Master Diff URL:

      Description

      Hi,

      sorry I'm not sure if is the good place for indicate this. I don't know how propose fix with Git.

      in 3.5beta+ (Build: 20180502),
      in boost theme, footer.mustache have the .hidden-lg-up classe.

      Boostrap 4 doc indicate the .hidden classes have been removed.
      May be use .d-none classe insteed.

      Also there is one .hidden-print in columns2.mustache. This classe have been renomed to .d-print-none (I think)

        Attachments

          Activity

            People

            Assignee:
            basbrands Bas Brands
            Reporter:
            philippematabiau Philippe Matabiau
            Peer reviewer:
            Mihail Geshoski
            Integrator:
            Andrew Nicols
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              17/May/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 20 minutes
                20m