Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62332

Grader report pagination error when using Boost

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.3.6, 3.4.3
    • Component/s: Gradebook, Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as admin or teacher.
      2. Create a course.
      3. Enrol students to the course.
        • make sure the number of student enrolments is greater than grade_report_studentsperpage in the Site administration.
      4. Go back to the Course.
      5. Navigate to Grades (/grade/report/grader/index.php?id=COURSEID).
      6. In Grader report
        • make sure the report table has pagination.
      7. Turn editing on and manually enter a grade anywhere, then save changes
      8. In the pagination controls, click the link for the page you are on.
        • make sure you are still on the current page and you do not see an error "A required parameter (id) was missing".
      Show
      Log in as admin or teacher. Create a course. Enrol students to the course. make sure the number of student enrolments is greater than grade_report_studentsperpage in the Site administration. Go back to the Course. Navigate to Grades (/grade/report/grader/index.php?id=COURSEID). In Grader report make sure the report table has pagination. Turn editing on and manually enter a grade anywhere, then save changes In the pagination controls, click the link for the page you are on. make sure you are still on the current page and you do not see an error "A required parameter (id) was missing".
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-62332-master

      Description

      As spotted by Khushbu Verma in MDLQA-11807:

      Steps to reproduce on site using the Boost theme:

      1. Log in as admin or teacher and go to a grader report which has pagination (i.e. the number of course enrolments is greater than grade_report_studentsperpage in the Site administration) e.g. https://qa.moodle.net/grade/report/grader/index.php?id=7
      2. Turn editing on and manually enter a grade anywhere, then save changes
      3. In the pagination controls, click the link for the page you are on.

      Expected result:

      The page you are on should not be a link. It's not a link when using Clean, only when using Boost.

      Actual result:

      An error message is displayed:

      A required parameter (id) was missing

      ×Debug info:
      Error code: missingparam
      ×Stack trace:
      line 482 of /lib/setuplib.php: moodle_exception thrown
      line 573 of /lib/moodlelib.php: call to print_error()
      line 31 of /grade/report/grader/index.php: call to required_param()

        Attachments

        1. screenshot-1.png
          screenshot-1.png
          18 kB
        2. step6_MDL-62332.PNG
          step6_MDL-62332.PNG
          17 kB
        3. step8_MDL-62332.PNG
          step8_MDL-62332.PNG
          42 kB

          Issue Links

            Activity

              People

              • Assignee:
                basbrands Bas Brands
                Reporter:
                tsala Helen Foster
                Peer reviewer:
                Mihail Geshoski
                Integrator:
                Jun Pataleta
                Tester:
                Anna Carissa Sadia
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Ryan Wyllie, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  17/May/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h