[MDL-62358] Question rendering API does not support all 'question numbers' that might be needed - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.3.6, 3.4.2, 3.5
Fix Version/s: 3.4.4, 3.5.1
Component/s: Questions
Labels:
- ci
- release_notes
- triaged

Testing Instructions:

Hide

The automated tests are a sufficient test of this. They verify that the change does not cause any regressions, and the new test verifies that other strings now work.

Show
The automated tests are a sufficient test of this. They verify that the change does not cause any regressions, and the new test verifies that other strings now work.
Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
https://github.com/HuongNV13/moodle
Pull 3.5 Branch:
~~MDL-62358~~-35
Pull 3.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_35_STABLE...HuongNV13:MDL-62358-35
Pull Master Branch:
~~MDL-62358~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...HuongNV13:MDL-62358-master

Description

For some reason, core_question_renderer::number only allows actual numbers, or the special case 'i'.

However, we had a case where we wanted to show "Question 1 of 10". There is no reason to prevent people using the question API from passing a string like '1 of 10' as $number.

Attachments

Activity

People

Assignee:

Huong Nguyen

Reporter:

Tim Hunt

Peer reviewer:

Tim Hunt

Integrator:

Eloy Lafuente (stronk7)

Tester:

CiBoT

Participants:

CiBoT, David Monllaó, Eloy Lafuente (stronk7), Huong Nguyen, Jun Pataleta, Tim Hunt

Component watchers:

Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:

2 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

09/May/18 6:54 AM

Updated:

03/Jul/18 6:30 AM

Resolved:

22/Jun/18 8:40 AM

Fix Release Date:

9/Jul/18