Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62358

Question rendering API does not support all 'question numbers' that might be needed

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      The automated tests are a sufficient test of this. They verify that the change does not cause any regressions, and the new test verifies that other strings now work.

      Show
      The automated tests are a sufficient test of this. They verify that the change does not cause any regressions, and the new test verifies that other strings now work.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-62358-master
    • Pull Master Diff URL:

      Description

      For some reason, core_question_renderer::number only allows actual numbers, or the special case 'i'.

      However, we had a case where we wanted to show "Question 1 of 10". There is no reason to prevent people using the question API from passing a string like '1 of 10' as $number.

        Attachments

          Activity

            People

            Assignee:
            HuongNV Huong Nguyen
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            Tim Hunt Tim Hunt
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            CiBoT CiBoT
            Participants:
            Component watchers:
            Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Jul/18