Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62362

phpunit failures with redis extension version 4.x

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.3.5, 3.4.2, 3.5
    • Fix Version/s: None
    • Component/s: General
    • Labels:
      None
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE

      Description

      Sort of related with MDL-60951...

      This failure is happening with any php70, php71 version, when using redis extension >= 4. With redis extension version 3.x it passes perfectly:

      $ vendor/bin/phpunit --verbose core_session_redis_testcase lib/tests/session_redis_test.php
      Moodle 3.5beta+ (Build: 20180508), 93ba31b27c3cef2bcc42bc17006c85f216e1c04f
      Php: 7.1.17, mysqli: 5.6.34, OS: Darwin 17.5.0 x86_64
      PHPUnit 6.5.7 by Sebastian Bergmann and contributors.
       
      Runtime:       PHP 7.1.17
      Configuration: /Users/stronk7/git_moodle/testing/phpunit.xml
       
      ......F.                                                            8 / 8 (100%)
       
      Time: 2.52 seconds, Memory: 36.00MB
       
      There was 1 failure:
       
      1) core_session_redis_testcase::test_session_exists_returns_valid_values
      Session must not exist yet, it has not been saved
      Failed asserting that 0 is false.
       
      /lib/tests/session_redis_test.php:229
      /lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit --verbose core_session_redis_testcase lib/tests/session_redis_test.php
       
      FAILURES!
      Tests: 8, Assertions: 75, Failures: 1.
      

      Maybe it's just a matter of accepting zero instead of false, maybe not. But for sure the version 4 of the extension changes that.

      Ciao

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: