Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62364

The notification_sent event should not require courseid

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.5
    • 3.5
    • Messages

      From David Mudrak -

      I am experiencing a regression while testing 3.5 upgrade of moodle.org which is likely related to this issue.

      Our custom plugin there is sending a notification that does not have the courseid set. The courseid is not a required property of \core\message\message as per its inline docs. Yet \core\message\manager::send_message() seems to expect it be part of the $eventdata.

      To clarify, it is \core\event\notification_sent which was introduced as a part of this issue, which throws exception when courseid is not set - see its validate_data() method.

       The thrown coding exception is

      The 'courseid' value must be set in other.
      

            markn Mark Nelson
            markn Mark Nelson
            David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
            David Monllaó David Monllaó
            CiBoT CiBoT
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.