Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62364

The notification_sent event should not require courseid

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.5
    • Component/s: Messages
    • Labels:

      Description

      From David Mudrak -

      I am experiencing a regression while testing 3.5 upgrade of moodle.org which is likely related to this issue.

      Our custom plugin there is sending a notification that does not have the courseid set. The courseid is not a required property of \core\message\message as per its inline docs. Yet \core\message\manager::send_message() seems to expect it be part of the $eventdata.

      To clarify, it is \core\event\notification_sent which was introduced as a part of this issue, which throws exception when courseid is not set - see its validate_data() method.

       The thrown coding exception is

      The 'courseid' value must be set in other.
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              markn Mark Nelson
              Peer reviewer:
              David Mudrák (@mudrd8mz)
              Integrator:
              David Monllaó
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18