Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62397

Data exporter does not recover from failure

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.3.5, 3.4.2, 3.5
    • Fix Version/s: 3.5
    • Component/s: Privacy
    • Labels:
    • Testing Instructions:
      Hide
      Setup
      1. Login as admin
      2. Open Site administration -> Users -> Define roles
      3. Create a new role:
        1. Upload the attached dpo.xml preset
        2. Create the role a the system context
      4. Open Site administration -> Users -> Assign system roles
      5. Assign your admin user to the role
      User requests
      1. Place the attached runadhoc.php script in your Moodle directory
      2. On the Command line, run: 

        php runadhoc.php

      3. Open Site administration -> Users -> Data requests
      4. Create a new export request for any user
        1. It should be shown as "Pending"
      5. Run runadhoc.php again
        1. Confirm that the output included detail of each component which was fetched
      6. In the UI, refresh the page
      7. Choose Actions => Approve request
      8. Run runadhoc.php again
      9. Cancel it just after it starts
      10. Run runadhoc.php again
        1. Confirm that it finishes
      Show
      Setup Login as admin Open Site administration -> Users -> Define roles Create a new role: Upload the attached dpo.xml preset Create the role a the system context Open Site administration -> Users -> Assign system roles Assign your admin user to the role User requests Place the attached runadhoc.php script in your Moodle directory On the Command line, run: php runadhoc.php Open Site administration -> Users -> Data requests Create a new export request for any user It should be shown as "Pending" Run runadhoc.php again Confirm that the output included detail of each component which was fetched In the UI, refresh the page Choose Actions => Approve request Run runadhoc.php again Cancel it just after it starts Run runadhoc.php again Confirm that it finishes
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-62397-master
    • Pull Master Diff URL:

      Description

      1. Start export
      2. Kill export mid-process
      3. re-run adhoc task
      4. Adhoc task errors about an in-progress task and exits

      Essentially we have a double lock which breaks things. Easy fix.

        Attachments

        1. dpo.xml
          26 kB
        2. runadhoc.php
          1 kB

          Activity

            People

            Assignee:
            dobedobedoh Andrew Lyons
            Reporter:
            dobedobedoh Andrew Lyons
            Peer reviewer:
            Mihail Geshoski Mihail Geshoski
            Integrator:
            David Monllaó David Monllaó
            Tester:
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              17/May/18