Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62419

Grader report white space using Boost and RTL language

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.5
    • Component/s: Gradebook, Themes
    • Labels:
    • Testing Instructions:
      Hide

      Test assignment submissions scroll

      1. Log in as admin.
      2. Create a new course with enrolled users.
      3. Install a RTL language pack, for example Hebrew.
      4. Add an assignment.
      5. Open the assignment and click the "View all Submissions" button.
      6. When scrolling horizontally on the submissions table ensure there is no empty space to scroll to.
      7. On this page switch to the RTL language.
      8. Check again if there is no empty horizontal space on page scroll.

      Test grading submissions scroll

      1. Continue in course from testing instructions above
      2. Click the grades link in the navdrawer
      3. When scrolling horizontally in the grades table ensure there is no empty space to scroll to.
      4. Switch to the RTL language
      5. Check again if there is no empty horizontal space on page scroll.

      Test other pages that use the .accesshide class: forms

      1. Add a new users.
      2. Open interests.
      3. Add tags.
      4. Switch to RTL language
      5. Add tags
      6. Check to see the text "Selected items:" is not displayed anywhere on the page. It can be found using browser search, but is not visible.

      Test other pages that use the .accesshide class: database

      1. Add a database activity
      2. Add 4 different type database fields
      3. When done add a single entry
      4. The page should not scroll horizontally showing off-screen content.
      5. When using browser search the field names used should be found twice on the page but only display once

      Repeat these tests using the latest versions of browsers in both RTL and LTR

      • Chrome
      • Firefox
      • Safari
      • Edge
      • Internet explorer
      • Mobile browser like IO safari

       

      Show
      Test assignment submissions scroll Log in as admin. Create a new course with enrolled users. Install a RTL language pack, for example Hebrew. Add an assignment. Open the assignment and click the "View all Submissions" button. When scrolling horizontally on the submissions table ensure there is no empty space to scroll to. On this page switch to the RTL language. Check again if there is no empty horizontal space on page scroll. Test grading submissions scroll Continue in course from testing instructions above Click the grades link in the navdrawer When scrolling horizontally in the grades table ensure there is no empty space to scroll to. Switch to the RTL language Check again if there is no empty horizontal space on page scroll. Test other pages that use the .accesshide class: forms Add a new users. Open interests. Add tags. Switch to RTL language Add tags Check to see the text "Selected items:" is not displayed anywhere on the page. It can be found using browser search, but is not visible. Test other pages that use the .accesshide class: database Add a database activity Add 4 different type database fields When done add a single entry The page should not scroll horizontally showing off-screen content. When using browser search the field names used should be found twice on the page but only display once Repeat these tests using the latest versions of browsers in both RTL and LTR Chrome Firefox Safari Edge Internet explorer Mobile browser like IO safari  
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-62419-master

      Description

      As reported by Chen Levy and Nadav Kavalerchik in MDLQA-12195:

      Steps to reproduce:

      1. View the grader report for a course containing several activities e.g. https://qa.moodle.net/grade/report/grader/index.php?id=2
      2. Set the language to a RTL language

      Expected result: The scrollbar at the bottom of the page enables you to scroll to the column containing the last activity.

      Actual result: The scrollbar enables you to scroll a lot further, as there is a lot of white space after the column containing the last activity.

      Note: This bug only affects sites using the Boost theme.

      Suggested fix from Nadav:

      .path-grade-report .accesshide {right: -10000px;}

        Attachments

        1. chrome.PNG
          chrome.PNG
          159 kB
        2. edge.PNG
          edge.PNG
          148 kB
        3. firefox.PNG
          firefox.PNG
          171 kB
        4. grader report showing white space.png
          grader report showing white space.png
          67 kB
        5. IE.PNG
          IE.PNG
          158 kB
        6. mobile.PNG
          mobile.PNG
          276 kB
        7. safari.PNG
          safari.PNG
          139 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  17/May/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours
                  5h